chore(ci): test Nim 2.2.4 and 2.2.10#2339
Conversation
There was a problem hiding this comment.
Pull request overview
Updates nim-libp2p’s pinned/tested Nim toolchain version references from v2.2.6 to v2.2.10 across CI, docs, and Docker-based build environments to keep the repo aligned with the intended supported compiler versions.
Changes:
- Bump GitHub Actions workflows using
nim_ref/ matrixreffromv2.2.6tov2.2.10. - Update Docker images used by simulation, interop, and performance test nodes to
nimlang/nim:2.2.10variants. - Update documentation references (README + Copilot instructions) to reflect Nim
v2.2.10support.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| simulation/Dockerfile | Updates build image Nim tag to 2.2.10 for simulation container builds. |
| performance/test_node/Dockerfile | Updates both build and runtime Nim images to 2.2.10 for perf test node container. |
| interop/transport/Dockerfile | Updates interop transport builder image to Nim 2.2.10. |
| interop/transport-v2/Dockerfile | Updates interop transport-v2 builder image to Nim 2.2.10. |
| interop/hole-punching/Dockerfile | Updates interop hole-punching builder image to Nim 2.2.10. |
| README.md | Updates stated supported Nim versions to include 2.2.10 (instead of 2.2.6). |
| .github/workflows/examples.yml | Runs examples workflow against Nim v2.2.10. |
| .github/workflows/daily_tests_no_flags.yml | Runs daily “no flags” tests on Nim v2.2.10. |
| .github/workflows/daily_i386.yml | Updates daily i386 matrix Nim v2.2.x entry to v2.2.10. |
| .github/workflows/daily_amd64.yml | Updates daily amd64 matrix Nim v2.2.x entry to v2.2.10. |
| .github/workflows/ci.yml | Updates main CI Nim matrix from v2.2.6 to v2.2.10. |
| .github/workflows/cbindings.yml | Updates cbindings workflow to use Nim v2.2.10. |
| .github/copilot-instructions.md | Updates documented CI Nim version reference to v2.2.10. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2339 +/- ##
==========================================
- Coverage 73.41% 73.40% -0.02%
==========================================
Files 168 168
Lines 22261 22261
Branches 20 20
==========================================
- Hits 16343 16340 -3
- Misses 5918 5921 +3 🚀 New features to boost your workflow:
|
| @@ -1,5 +1,5 @@ | |||
| # syntax=docker/dockerfile:1.5-labs | |||
| FROM nimlang/nim:2.2.6-ubuntu-regular as builder | |||
| FROM nimlang/nim:2.2.10-ubuntu-regular as builder | |||
There was a problem hiding this comment.
from ci:
ERROR: failed to build: failed to solve: nimlang/nim:2.2.10-ubuntu-regular: failed to resolve source metadata for docker.io/nimlang/nim:2.2.10-ubuntu-regular: docker.io/nimlang/nim:2.2.10-ubuntu-regular: not found
There was a problem hiding this comment.
pinging @moigagoo, he might know more....
There was a problem hiding this comment.
@narimiran thanks for the ping!
As part of the preparation for making the images official (docker-library/official-images#19453), I've removed a lot of cruft and switched to the officially encouraged tag naming.
This should work:
FROM nimlang/nim:2.2.10 as builderUbuntu regular is now the only flavor being shipped so ubuntu-regular is redundant.
|
🤔 it seems it can't find "redis" with this change? https://github.com/vacp2p/nim-libp2p/actions/runs/24987822171/job/73165496804?pr=2339 |
From what I can tell, See if you maybe need to change some package versions in |
Yep, that indeed seems to be the case: #2348 (comment) |
This should fix the failing dependency resolution.
|
@narimiran, I am not sure what is this |
How about leaving 2.0.16 as it were, and just add 2.2.10? (Like it was done initially in this PR, before I got the idea from #2343) |
|
On the other hand, now I've seen #2380 - so let's rebase/merge it one more time and see if that helps. |
|
IT'S GREEN!!! IT'S FINALLY GREEN!! There were a lot of debug commits and banging my head on wall (rebased, so not visible anymore), but the problematic interop test is finally green! Should be ready for merge now. (cc @richard-ramos) |
|
lol that test was cursed, good catch on the nimble ordering, @narimiran! |
Summary
This PR updates the used/tested Nim version from 2.2.6 to 2.2.10.
EDIT: And, as added later on (based on #2343), it also replaces Nim 2.0.16 with 2.2.4.
Compatibility & Downstream Validation
Nim 2.2.10 allows
nim-libp2ptests to also run with--mm:orc. (Not part of this PR)References
First tested in #2148, but here is a complete search-and-replace of v2.2.6 with v2.2.10.