Skip to content

chore(ci): test Nim 2.2.4 and 2.2.10 #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richard-ramos merged 10 commits into from
May 1, 2026
Merged

chore(ci): test Nim 2.2.4 and 2.2.10 #2339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
71cba29
chore: use Nim 2.2.10
narimiran Apr 24, 2026
faeaaca
Fix Nim Docker Hub image tag.
moigagoo Apr 27, 2026
0666f8a
change dockerfiles
narimiran Apr 27, 2026
8978b07
test Nim 2.2.4 instead of 2.0.16
narimiran Apr 27, 2026
0b76a15
Merge branch 'master' into nim-2210
narimiran Apr 29, 2026
9980cec
bump pinned bearssl version to 0.2.8
narimiran Apr 29, 2026
8796c63
Merge branch 'master' into nim-2210
richard-ramos Apr 30, 2026
75b19e9
Merge branch 'master' into nim-2210
narimiran Apr 30, 2026
34b855d
Merge branch 'master' into nim-2210
narimiran May 1, 2026
ee62dae
nimble install: change the order
narimiran May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ nimble examples # Build and run C examples

| Workflow | Description |
|----------|-------------|
| `ci.yml` | Main CI: Linux (amd64/i386), macOS (arm64), Windows; Nim v2.0.16 & v2.2.6 |
| `ci.yml` | Main CI: Linux (amd64/i386), macOS (arm64), Windows; Nim v2.0.16 & v2.2.10 |
| `daily_amd64.yml` / `daily_i386.yml` | Extended daily tests |
| `daily_ci_report.yml` | Daily CI failure reporting: opens/updates GitHub issues for failed daily CI runs |
| `daily_common.yml` | Shared steps/config reused by daily workflows |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cbindings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
shell: bash
os: linux
cpu: amd64
nim_ref: v2.2.6
nim_ref: v2.2.10

- name: Restore deps from cache
id: deps-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
nim:
- ref: v2.0.16
memory_management: refc
- ref: v2.2.6
- ref: v2.2.10
memory_management: refc
include:
- platform:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily_amd64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
with:
nim: "[
{'ref': 'v2.0.16', 'memory_management': 'refc'},
{'ref': 'v2.2.6', 'memory_management': 'refc'},
{'ref': 'v2.2.10', 'memory_management': 'refc'},
{'ref': 'devel', 'memory_management': 'refc'},
]"
configuration: "[
Expand All @@ -37,7 +37,7 @@ jobs:
pinned_deps: true
nim: "[
{'ref': 'v2.0.16', 'memory_management': 'refc'},
{'ref': 'v2.2.6', 'memory_management': 'refc'},
{'ref': 'v2.2.10', 'memory_management': 'refc'},
{'ref': 'devel', 'memory_management': 'refc'},
]"
configuration: "[
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily_i386.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
with:
nim: "[
{'ref': 'v2.0.16', 'memory_management': 'refc'},
{'ref': 'v2.2.6', 'memory_management': 'refc'},
{'ref': 'v2.2.10', 'memory_management': 'refc'},
{'ref': 'devel', 'memory_management': 'refc'},
]"
configuration: "[
Expand All @@ -29,7 +29,7 @@ jobs:
pinned_deps: true
nim: "[
{'ref': 'v2.0.16', 'memory_management': 'refc'},
{'ref': 'v2.2.6', 'memory_management': 'refc'},
{'ref': 'v2.2.10', 'memory_management': 'refc'},
{'ref': 'devel', 'memory_management': 'refc'},
]"
configuration: "[
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/daily_tests_no_flags.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
shell: bash
os: linux
cpu: amd64
nim_ref: v2.2.6
nim_ref: v2.2.10

- name: Restore deps from cache
id: deps-cache
Expand All @@ -46,5 +46,3 @@ jobs:
- name: Build and run tests without feature flags
run: |
nim c -r tests/test_all.nim


2 changes: 1 addition & 1 deletion .github/workflows/examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
shell: bash
os: linux
cpu: amd64
nim_ref: v2.2.6
nim_ref: v2.2.10

- name: Restore deps from cache
id: deps-cache
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Jump into the [contributing](docs/contributing.md) page to get started, `nim-lib

## Install

The currently supported Nim versions are v2.0.16 and v2.2.6.
The currently supported Nim versions are v2.0.16 and v2.2.10.

```
nimble install libp2p
Expand Down Expand Up @@ -143,4 +143,4 @@ List of packages modules implemented in nim-libp2p:
| **Privacy** | |
| [mix](nim-libp2p/libp2p/protocols/mix.nim) | [Mix](https://lip.logos.co/ift-ts/raw/mix.html#5-protocol-overview) network protocol with [Sphinx](https://cypherpunks.ca/~iang/pubs/Sphinx_Oakland09.pdf) packet format for anonymity |
| **Performance** | |
| [perf](nim-libp2p/libp2p/protocols/perf/core.nim) | [Perf](https://github.com/libp2p/specs/blob/master/perf/perf.md) protocol for benchmarking libp2p nodes |
| [perf](nim-libp2p/libp2p/protocols/perf/core.nim) | [Perf](https://github.com/libp2p/specs/blob/master/perf/perf.md) protocol for benchmarking libp2p nodes |
2 changes: 1 addition & 1 deletion interop/hole-punching/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.5-labs
FROM nimlang/nim:2.2.6-ubuntu-regular as builder
FROM nimlang/nim:2.2.10-ubuntu-regular as builder

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion interop/transport-v2/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.5-labs
FROM nimlang/nim:2.2.6-ubuntu-regular as builder
FROM nimlang/nim:2.2.10-ubuntu-regular as builder

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion interop/transport/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# syntax=docker/dockerfile:1.5-labs
FROM nimlang/nim:2.2.6-ubuntu-regular as builder
FROM nimlang/nim:2.2.10-ubuntu-regular as builder
Copy link
Copy Markdown
Member

@vladopajic vladopajic Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from ci:

ERROR: failed to build: failed to solve: nimlang/nim:2.2.10-ubuntu-regular: failed to resolve source metadata for docker.io/nimlang/nim:2.2.10-ubuntu-regular: docker.io/nimlang/nim:2.2.10-ubuntu-regular: not found

Copy link
Copy Markdown
Contributor Author

@narimiran narimiran Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinging @moigagoo, he might know more....

Copy link
Copy Markdown

@moigagoo moigagoo Apr 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narimiran thanks for the ping!

As part of the preparation for making the images official (docker-library/official-images#19453), I've removed a lot of cruft and switched to the officially encouraged tag naming.

This should work:

FROM nimlang/nim:2.2.10 as builder

Ubuntu regular is now the only flavor being shipped so ubuntu-regular is redundant.


WORKDIR /app

Expand Down
6 changes: 3 additions & 3 deletions performance/test_node/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Create the build image
FROM nimlang/nim:2.2.6-ubuntu-regular AS build
FROM nimlang/nim:2.2.10-ubuntu-regular AS build

WORKDIR /node

Expand All @@ -19,7 +19,7 @@ RUN nimble c \
performance/test_node/main.nim


FROM nimlang/nim:2.2.6-alpine-slim
FROM nimlang/nim:2.2.10-alpine-slim
Comment thread
narimiran marked this conversation as resolved.
Outdated

WORKDIR /node

Expand All @@ -31,4 +31,4 @@ RUN chmod +x main entrypoint.sh \

VOLUME ["/output"]

ENTRYPOINT ["/node/entrypoint.sh"]
ENTRYPOINT ["/node/entrypoint.sh"]
2 changes: 1 addition & 1 deletion simulation/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Build context must be the repo root:
# docker build -f simulation/Dockerfile -t nim-libp2p/simulation .
FROM nimlang/nim:2.2.6-ubuntu-regular AS build
FROM nimlang/nim:2.2.10-ubuntu-regular AS build

WORKDIR /node
COPY . .
Expand Down
Loading