chore(ci): test with 2.2.4 (nimbus) and 2.2.10 #2343
Closed
gmelodie wants to merge 4 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2343 +/- ##
==========================================
- Coverage 73.42% 73.39% -0.04%
==========================================
Files 168 168
Lines 22221 22221
Branches 20 20
==========================================
- Hits 16316 16309 -7
- Misses 5905 5912 +7 🚀 New features to boost your workflow:
|
Contributor
|
This only changes the tested Nim versions in |
Contributor
|
Or, more generally: I don't understand the point of this PR — why open this PR instead of commenting/modifying #2339 if something there needs changing? |
Contributor
Author
|
@narimiran sure, please do |
auto-merge was automatically disabled
April 27, 2026 16:22
Pull request was closed
narimiran
added a commit
to narimiran/nim-libp2p
that referenced
this pull request
Apr 27, 2026
As seen in vacp2p#2343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop support for Nim 2.0.16 and 2.2.6 in CI, replacing them with 2.2.10 and 2.2.4 respectively. This keeps the test matrix on actively maintained 2.2.x releases and removes the legacy 2.0.x line.
.github/workflows/ci.yml:README.md:Affected Areas
Two Nim versions in the CI matrix updated; no source changes.
Compatibility & Downstream Validation
No library code changed. All existing encode/decode and API paths are unaffected. Downstream consumers (Nimbus, Waku, Codex) should validate that their own builds are compatible with Nim 2.2.4 and 2.2.10 if they pin to the versions advertised here.
Impact on Library Users
Risk Assessment
References
#2339