[feat i2g]add in-cluster console for model comparison by shuqz · Pull Request #4728 · kubernetes-sigs/aws-load-balancer-controller

shuqz · 2026-05-07T05:20:44Z

Description

this is a large PR, see each commit for breakdown
for commit 0923067, can focus on changes under /console
pkg/ingress2gateway/console/static/index.html is a large file since it is UI -> maybe it is better to actually try out console following documentation instructions
163696d contains complete documentation for in-cluster console, start from there
the change is mostly for console with a bug fix in migration tool

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

k8s-ci-robot · 2026-05-07T05:21:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shuqz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [shuqz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov-commenter · 2026-05-07T05:29:43Z

Codecov Report

❌ Patch coverage is 82.87154% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.52%. Comparing base (22cdb42) to head (868bf04).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/ingress2gateway/console/server.go	67.04%	22 Missing and 7 partials ⚠️
pkg/ingress2gateway/console/discovery.go	77.47%	14 Missing and 11 partials ⚠️
pkg/ingress2gateway/console/classify.go	90.00%	3 Missing and 1 partial ⚠️
pkg/ingress2gateway/console/correlate.go	81.81%	2 Missing and 2 partials ⚠️
pkg/ingress2gateway/console/differ.go	96.33%	4 Missing ⚠️
pkg/ingress2gateway/console/model.go	92.59%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4728      +/-   ##
==========================================
+ Coverage   56.09%   56.52%   +0.43%     
==========================================
  Files         388      394       +6     
  Lines       30932    31381     +449     
==========================================
+ Hits        17352    17739     +387     
- Misses      12566    12607      +41     
- Partials     1014     1035      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

k8s-triage-robot · 2026-05-07T07:38:43Z

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

shuqz · 2026-05-07T16:58:39Z

 	r.logger.Info("successfully built model", "model", stackJSON)

+	if r.featureGates.Enabled(config.IngressPlanAnnotation) && len(ingGroup.Members) > 0 {
+		if err := patchDryRunPlanAnnotation(ctx, r.k8sClient, ingGroup.Members[0].Ing, stackJSON); err != nil {


it is always patched to members[0] for group ingress. members in a group is sorted by group order. if group order is not specified, it is sorted by lexical order based on namespacedName. i think it is deterministic. and even if it changed, we will still pick up the new members[0] to write annotation and cleanup stale annotations (see line 239 below). as for how it is been discovered from gateway, gateway will list all ingress from a group and find one with dry run plan annotation.

let me know if you still prefer to write it to oldest ingress

shuqz · 2026-05-07T18:11:37Z

 These warnings are informational — the tool still generates output. For the most accurate results, use `--from-cluster` which automatically fetches all referenced resources.

+## Migration Console (Web UI)
+


i am going to create a new page for console, including screenshot from console as example and instructions to use. but just make it short here

shuqz · 2026-05-07T18:14:49Z

@@ -0,0 +1,112 @@
+package console


please review this file. this is where we define which changes are "Expected"

bobert-2 · 2026-05-08T22:08:02Z

+const escapeHTML = (s) => String(s).replace(/[&<>"']/g, c => (
+  { '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' }[c]
+));


Do any other characters need to be escaped? Ex. =, /

bobert-2 · 2026-05-08T22:10:10Z

+      `<div class="error-msg">${escapeHTML(gw.error)}</div>`);
+    return;
+  }
+  document.querySelectorAll('.error-msg').forEach(e => e.remove());


Why do we want to remove the error messages?

clears stale error messages from the DOM when navigating

sarevalo2002 · 2026-05-08T22:38:37Z

+.gw-rail-label {
+  display: none;
+  align-items: center;
+  padding: 0 16px;


There's a lot of "magic numbers" in the CSS. Could you also define some of the more common ones (like 12px, 16px, etc.) in :root, similar to what you did for some of the more common colors so it's clear why they're set at those sizes?

sarevalo2002 · 2026-05-08T22:41:16Z

+<!-- TOPBAR -->
+<header class="topbar">
+  <a class="brand" href="/" id="brand" aria-label="Home">
+    <span class="brand-wordmark">aws<span class="kbd">›</span></span>


Nit: Would double check that most class names are readable. Using this as an example, I'm not too sure what kbd represents.

sarevalo2002 · 2026-05-08T22:57:18Z

+
+  let target = viewLeft;
+  if (tabLeft < viewLeft) {
+    target = tabLeft - 12; // small gutter


Similar comment about magic numbers, would be good to define these constants somewhere with descriptive names so it's understood why this number in particular is chosen as the gutter size. Also makes adjusting the size easier down the line as adjusting a constant is easier than many instances of 12.

…igs#4734) The IngressPlanAnnotation feature gate, dryrun.go controller logic, and related helm/docs changes are now in a separate PR. This branch retains only the IngressSuffixDryRunPlan constant which the console reads from existing ingress annotations.

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 7, 2026

k8s-ci-robot requested review from oliviassss and wweiwei-li May 7, 2026 05:21

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2026

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2026

shuqz commented May 7, 2026

View reviewed changes

shuqz mentioned this pull request May 7, 2026

[feat i2g]add feature flag for ingress plan annotation #4722

Closed

6 tasks

shuqz commented May 7, 2026

View reviewed changes

bobert-2 reviewed May 8, 2026

View reviewed changes

sarevalo2002 reviewed May 8, 2026

View reviewed changes

shuqz mentioned this pull request May 11, 2026

[feat i2g]support split by namespace output #4733

Merged

6 tasks

shuqz added 6 commits May 12, 2026 13:20

[feat i2g]add feature flag for ingress plan annotation

3f24a1b

[feat i2g]set up infra for console display

aec13d0

[feat i2g]add in-cluster console for model comparison

83fd5e3

add documentation for in-cluster-console

a4508d4

add check in classify for default value

9c7964e

update in-cluster console

3edf139

shuqz force-pushed the in-cluster-console branch from ad76b35 to 3edf139 Compare May 12, 2026 20:26

shuqz added 2 commits May 12, 2026 13:51

Remove translate/userTag changes (moved to PR kubernetes-sigs#4735)

868bf04

shuqz mentioned this pull request May 12, 2026

[feat i2g] Add IngressPlanAnnotation feature gate for dry-run plan #4734

Merged

6 tasks

		These warnings are informational — the tool still generates output. For the most accurate results, use `--from-cluster` which automatically fetches all referenced resources.

		## Migration Console (Web UI)

Conversation

shuqz commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Uh oh!

k8s-ci-robot commented May 7, 2026

Uh oh!

codecov-commenter commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

k8s-triage-robot commented May 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shuqz commented May 7, 2026 •

edited

Loading

codecov-commenter commented May 7, 2026 •

edited

Loading