[feat i2g] Add IngressPlanAnnotation feature gate for dry-run plan#4734
Merged
Merged
Conversation
When enabled, the ingress controller writes the serialized model stack JSON to alb.ingress.kubernetes.io/dry-run-plan on the primary ingress after each reconcile. For grouped ingresses, the annotation is written to the first member (lowest group order) and cleared from non-primary members to maintain a single-holder invariant. This supports the migration console's ability to compare ingress and gateway models side by side without calling AWS.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
shuqz
changed the title
shuqz
added a commit
to shuqz/shuqz-aws-load-balancer-controller
that referenced
this pull request
May 12, 2026
…igs#4734) The IngressPlanAnnotation feature gate, dryrun.go controller logic, and related helm/docs changes are now in a separate PR. This branch retains only the IngressSuffixDryRunPlan constant which the console reads from existing ingress annotations.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4734 +/- ##
==========================================
+ Coverage 56.09% 56.15% +0.05%
==========================================
Files 388 389 +1
Lines 30932 31010 +78
==========================================
+ Hits 17352 17413 +61
- Misses 12566 12582 +16
- Partials 1014 1015 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shraddhabang
approved these changes
May 12, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, shuqz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/approved |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Prerequisite for the in-cluster migration console (#4728).
Description
Adds an
IngressPlanAnnotationfeature gate (default: disabled). When enabled, the ingress controller writes the serialized model stack JSON toalb.ingress.kubernetes.io/dry-run-planon the primary ingress after each reconcile.For grouped ingresses, the annotation is written to the first member (lowest group order) and cleared from non-primary members to maintain a single-holder invariant. This allows the migration console to locate and compare ingress vs gateway models without ambiguity.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯