[feat i2g]add feature flag for ingress plan annotation#4722
Closed
shuqz wants to merge 1 commit into
Closed
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shuqz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4722 +/- ##
==========================================
+ Coverage 56.09% 56.13% +0.03%
==========================================
Files 388 389 +1
Lines 30932 30987 +55
==========================================
+ Hits 17352 17395 +43
- Misses 12566 12578 +12
Partials 1014 1014 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shraddhabang
reviewed
May 5, 2026
| // controller writes the dry-run-plan annotation to. This is Members[0] after sorting | ||
| // by group.order (default 0), with ties broken by lexical namespace/name — the same | ||
| // logic used by the ingress controller's group loader. | ||
| func findPlanHolder(members []networking.Ingress) string { |
Collaborator
There was a problem hiding this comment.
Can you write unit tests for this?
Collaborator
Author
|
closed in favor of #4728 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
gateway.k8s.aws/ingress-plan-holder: member[0]'s namespaced name, this will be used later in in-cluster console for model comparison. with this, console can use kubectl to quickly looks up specific ingress and its ingress dry-run-plan annotationChecklist
README.md, or thedocsdirectory)example generate gateway from group ingress:
example generated gateway from single ingress
BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯