Feature topic monitor (backport #605 to ros2-kilted)#608
Open
mergify[bot] wants to merge 1 commit into
Open
Conversation
* Original topic monitor version for galactic * Rename to diagnostic_topic_monitor * Refactor code and package (#1) * Add topic monitor components to diagnostics Co-authored-by: Tejas Kumar Shastha <tejas.kumarshastha@de.bosch.com> Signed-off-by: Ingo Lütkebohle <ingo.luetkebohle@de.bosch.com> * Fix license tag * Add new package to lint and test * Fix copyright notices * author under license Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * flake8 Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * cpplint Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * quotes Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * ' Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * target_link_libraries Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * imperative Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * flake8 Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * flakes Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * whitespace Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * windows edge case Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * windows why Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * may also be bigger Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * issues w/ defines Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * windows Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * fixes #592 and #526 Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * missing test dep Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * three different publishers Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * taking more time Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * testing for all 4 topics Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * this did lead to -1 as lowest level in corner cases Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * fix Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Ingo Lütkebohle <ingo.luetkebohle@de.bosch.com> Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Ingo Lütkebohle (CR/ASD1) <ingo.luetkebohle@de.bosch.com> Co-authored-by: Tejas Kumar Shastha <tejas.shastha@gmail.com> Co-authored-by: Tejas Kumar Shastha <tejas.kumarshastha@de.bosch.com> (cherry picked from commit 207fe69)
mergify
Bot
added
the
automerge
ct2034
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy of #476
This was merged already because it did build fine in CI (e.g. kilted: https://github.com/ros/diagnostics/actions/runs/26198174893, the rolling job is broken because of the broken docker image) and built fine for me locally.
But it made problems on the buildfarm (on all distros, but here is kilted for comparison: https://build.ros2.org/job/Kdev__diagnostics__ubuntu_noble_amd64/36/changes
@iluetkeb Could you please have a look?
This is an automatic backport of pull request #605 done by Mergify.