Add the possibility to monitor multiple hard drives#514
Open
Omega3395 wants to merge 2 commits into
Open
Conversation
ct2034
added
the
enhancement
ct2034
requested changes
May 21, 2026
| self._updater = Updater(self) | ||
| self._updater.setHardwareID(hostname) | ||
| self._updater.add(f'{hostname} HD Usage', self.check_disk_usage) | ||
| self._updater.setHardwareID("main_pc") |
|
|
||
| # Add diagnostic check for each path | ||
| for i, path in enumerate(self._paths): | ||
| self._updater.add(f'HD Usage {i}', lambda diag, idx=i: self.check_disk_usage(diag, idx)) |
Collaborator
There was a problem hiding this comment.
can we have the path in here
| self.add_on_set_parameters_callback(self.callback_config) | ||
| self.declare_parameter('path', self._path, ParameterDescriptor( | ||
| description='Path in which to check remaining space.')) | ||
| self.declare_parameter('path', self._paths, ParameterDescriptor( |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.declare_parameter('path', self._paths, ParameterDescriptor( | |
| self.declare_parameter('paths', self._paths, ParameterDescriptor( |
Please change this everywhere accordingly
Comment on lines
108
to
+110
| if param.name == 'path': | ||
| self._path = str( | ||
| Path(param.value).expanduser().resolve(strict=True) | ||
| ) | ||
| # Handle both single path (string) and multiple paths (array) | ||
| if isinstance(param.value, str): |
Collaborator
There was a problem hiding this comment.
we could also additionally keep the path param for backwards compatibility. what do you think?
| return SetParametersResult(successful=True) | ||
|
|
||
| def check_disk_usage(self, diag: DiagnosticStatus) -> DiagnosticStatus: | ||
| def check_disk_usage(self, diag: DiagnosticStatus, path_index: int = 0) -> DiagnosticStatus: |
Collaborator
There was a problem hiding this comment.
why introduce an index here? why no by path directly?
| diag.level = DiagnosticStatus.ERROR | ||
|
|
||
| total_go = total // (1024 * 1024) | ||
| total_gb = total // (1024 ** 3) |
Collaborator
There was a problem hiding this comment.
was this wrong? Why is it ^3 now?
ct2034
added
the
needs more work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the possibility to monitor multiple hard drives within a single instance of the node (it was previously possible to do it with multiple hd_monitor instances).