Skip to content

RetryIter fast-forward support#4732

Merged
AhmedSoliman merged 1 commit into
mainfrom
pr4732
May 14, 2026
Merged

RetryIter fast-forward support#4732
AhmedSoliman merged 1 commit into
mainfrom
pr4732

Conversation

@AhmedSoliman
Copy link
Copy Markdown
Contributor

@AhmedSoliman AhmedSoliman commented May 13, 2026

Allow retry iterator be fast-forwarded to match a known number of attempts that has been made in previous incarinations.


Stack created with Sapling. Best reviewed with ReviewStack.

@AhmedSoliman AhmedSoliman marked this pull request as ready for review May 13, 2026 15:03
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70ae92308a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/types/src/retries.rs
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Test Results

  8 files  ±0    8 suites  ±0   4m 47s ⏱️ +6s
 50 tests ±0   50 ✅ ±0  0 💤 ±0  0 ❌ ±0 
218 runs  ±0  218 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3f7c310. ± Comparison against base commit 9f4a6e3.

♻️ This comment has been updated with latest results.

@AhmedSoliman
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4063e17572

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/types/src/retries.rs
Allow retry iterator be fast-forwarded to match a known number of attempts that has been made in previous incarinations.
@AhmedSoliman AhmedSoliman merged commit 3f7c310 into main May 14, 2026
61 checks passed
@AhmedSoliman AhmedSoliman deleted the pr4732 branch May 14, 2026 07:53
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant