[Yield] Support invocations to yield on transient errors#4725
Open
AhmedSoliman wants to merge 1 commit into
Open
[Yield] Support invocations to yield on transient errors#4725AhmedSoliman wants to merge 1 commit into
AhmedSoliman wants to merge 1 commit into
Conversation
Test Results 8 files ± 0 8 suites ±0 2m 43s ⏱️ - 2m 6s Results for commit 96b03fe. ± Comparison against base commit 5ea7c39. This pull request removes 17 tests.♻️ This comment has been updated with latest results. |
AhmedSoliman
changed the title
AhmedSoliman
force-pushed
the
pr4725
branch
2 times, most recently
from
b824fb7 to
c8ebcb2
Compare
AhmedSoliman
force-pushed
the
pr4725
branch
2 times, most recently
from
1b4b644 to
3c4e111
Compare
AhmedSoliman
force-pushed
the
pr4725
branch
4 times, most recently
from
a0d3f06 to
90f61fc
Compare
tillrohrmann
approved these changes
May 18, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Great work @AhmedSoliman 🚀 Looking forward to finally releasing invoker slots when retrying for prolonged times :-) LGTM. +1 for merging.
|
|
||
| use restate_util_time::{FriendlyDuration, NonZeroFriendlyDuration}; | ||
|
|
||
| const DEFAULT_INVOCATION_YIELD_THRESHOLD: FriendlyDuration = FriendlyDuration::from_secs(2); |
Contributor
There was a problem hiding this comment.
A comment in the invocation state machine said that the threshold is 1 second.
| bilrost::empty_state_via_default!(ByteCount<true>); | ||
|
|
||
| bilrost::delegate_proxied_encoding!( | ||
| use encoding (bilrost::encoding::Varint) |
Contributor
There was a problem hiding this comment.
Why are we encoding ByteCount as a varint? Is the space saving benefit big enough for the added decoding cycles? Or is it because of wire compatibility with another format?
| bilrost::empty_state_via_for_overwrite!(ByteCount<false>); | ||
|
|
||
| bilrost::delegate_proxied_encoding!( | ||
| use encoding (bilrost::encoding::Varint) |
Full implementation for yielding invocations from the invoker back to the vqueues scheduler. This unifies with the existing support for memory-budget-based invocation yielding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full implementation for yielding invocations from the invoker back to the vqueues scheduler. This unifies with the existing support for memory-budget-based invocation yielding.
Stack created with Sapling. Best reviewed with ReviewStack.