Skip to content

chore: forward props in drawer header #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 2 commits into from
May 22, 2026
Merged

chore: forward props in drawer header #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4601485
chore: forward props in drawer header
rohanchkrabrty May 21, 2026
5522dc2
chore: remove redundant display
rohanchkrabrty May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/raystack/components/drawer/drawer-misc.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@

import { Drawer as DrawerPrimitive } from '@base-ui/react/drawer';
import { cx } from 'class-variance-authority';
import { ComponentProps, type ReactNode } from 'react';
import { ComponentProps } from 'react';
import styles from './drawer.module.css';

export const DrawerHeader = ({
children,
className
}: {
children: ReactNode;
className?: string;
}) => <div className={cx(styles.header, className)}>{children}</div>;
className,
...props
}: ComponentProps<'div'>) => (
<div className={cx(styles.header, className)} {...props} />
);
DrawerHeader.displayName = 'Drawer.Header';

export function DrawerTitle({
Expand Down
1 change: 0 additions & 1 deletion packages/raystack/components/spinner/spinner.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.spinner {
display: inline-block;
position: relative;
display: flex;
Copy link
Copy Markdown
Contributor

@paanSinghCoder paanSinghCoder May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

display: flex; and justify-content: center; are also not required as the .spinner only renders 8 poles that are absolutely positioned. Only css required here is position: relative;. Please confirm once.

Copy link
Copy Markdown
Contributor Author

@rohanchkrabrty rohanchkrabrty May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed because the the sub items are aligned at center and then transformed against.

justify-content: center;
Expand Down
Loading