chore: forward props in drawer header#817
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| .spinner { | ||
| display: inline-block; | ||
| position: relative; | ||
| display: flex; |
There was a problem hiding this comment.
display: flex; and justify-content: center; are also not required as the .spinner only renders 8 poles that are absolutely positioned. Only css required here is position: relative;. Please confirm once.
There was a problem hiding this comment.
It's needed because the the sub items are aligned at center and then transformed against.
Summary
divprops ontoDrawer.Headerso callers can passid,role,aria-*, event handlers, etc.{ children, className }prop type withComponentProps<'div'>for full HTML compatibility.ReactNodeimport.