Skip to content

[release-ocm-2.15] MGMT-24115: allow empty image checksum/url in getChecksumAndURL#10338

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-ocm-2.15from
openshift-cherrypick-robot:cherry-pick-10325-to-release-ocm-2.15
Open

[release-ocm-2.15] MGMT-24115: allow empty image checksum/url in getChecksumAndURL#10338
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-ocm-2.15from
openshift-cherrypick-robot:cherry-pick-10325-to-release-ocm-2.15

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #10325

/assign omer-vishlitzky

Since OCP 4.10, openshift-install generates Machine ProviderSpecs
with customDeploy instead of image data. The image checksum and
url fields are empty strings. Commit b19f29b added empty-string
validation that treats these as fatal errors, preventing spoke
Machine creation for day-2 BMH-backed nodes. The spoke Machine
is needed by cluster-machine-approver to auto-approve CSRs.

Removes the empty-string checks while keeping all nil/type safety checks.
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 17, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-24115

Details

In response to this:

This is an automated cherry-pick of #10325

/assign omer-vishlitzky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7446661e-a77c-4cb2-bfec-1d618431f960

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2026
@openshift-ci openshift-ci Bot requested review from adriengentil and oourfali May 17, 2026 10:58
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign pastequo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.51%. Comparing base (20c4776) to head (58be9cf).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.15   #10338      +/-   ##
====================================================
- Coverage             43.51%   43.51%   -0.01%     
====================================================
  Files                   407      407              
  Lines                 70596    70592       -4     
====================================================
- Hits                  30719    30717       -2     
+ Misses                37137    37136       -1     
+ Partials               2740     2739       -1     
Files with missing lines Coverage Δ
...nal/controller/controllers/bmh_agent_controller.go 76.05% <ø> (-0.09%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 17, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-disconnected-capi 58be9cf link true /test e2e-ai-operator-disconnected-capi
ci/prow/e2e-ai-operator-ztp-capi 58be9cf link true /test e2e-ai-operator-ztp-capi
ci/prow/e2e-ai-operator-ztp 58be9cf link true /test e2e-ai-operator-ztp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants