[release-ocm-2.15] MGMT-24115: allow empty image checksum/url in getChecksumAndURL#10338
Conversation
Since OCP 4.10, openshift-install generates Machine ProviderSpecs with customDeploy instead of image data. The image checksum and url fields are empty strings. Commit b19f29b added empty-string validation that treats these as fatal errors, preventing spoke Machine creation for day-2 BMH-backed nodes. The spoke Machine is needed by cluster-machine-approver to auto-approve CSRs. Removes the empty-string checks while keeping all nil/type safety checks.
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-24115 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.15 #10338 +/- ##
====================================================
- Coverage 43.51% 43.51% -0.01%
====================================================
Files 407 407
Lines 70596 70592 -4
====================================================
- Hits 30719 30717 -2
+ Misses 37137 37136 -1
+ Partials 2740 2739 -1
🚀 New features to boost your workflow:
|
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #10325
/assign omer-vishlitzky