MGMT-24115: [release-ocm-2.16] allow empty image checksum/url in getChecksumAndURL#10325
Conversation
Since OCP 4.10, openshift-install generates Machine ProviderSpecs with customDeploy instead of image data. The image checksum and url fields are empty strings. Commit b19f29b added empty-string validation that treats these as fatal errors, preventing spoke Machine creation for day-2 BMH-backed nodes. The spoke Machine is needed by cluster-machine-approver to auto-approve CSRs. Removes the empty-string checks while keeping all nil/type safety checks.
openshift-ci-robot
added
the
jira/valid-reference
|
@omer-vishlitzky: This pull request references MGMT-24115 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.16 #10325 +/- ##
====================================================
- Coverage 43.99% 43.99% -0.01%
====================================================
Files 415 415
Lines 72074 72070 -4
====================================================
- Hits 31709 31704 -5
- Misses 37479 37480 +1
Partials 2886 2886
🚀 New features to boost your workflow:
|
|
/retest |
|
@omer-vishlitzky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, omer-vishlitzky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit 6d1d94e
into
openshift:release-ocm-2.16
|
/cherry-pick release-ocm-2.15 |
|
@omer-vishlitzky: new pull request created: #10338 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Cherry-pick of #10246 to release-ocm-2.16.
https://redhat.atlassian.net/browse/MGMT-24115
Day-2 node CSR auto-approval fails because no Machine object is created for BMH-backed nodes. Since OCP 4.10, openshift-install generates Machine ProviderSpecs with customDeploy and empty image checksum/url. The empty-string validation rejects these, preventing spoke Machine creation.
Removes the empty-string checks while keeping all nil/type safety checks.