Skip to content

Move config parsing and CRD metrics from apis to internal package #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swiatekm merged 9 commits into from
May 13, 2026
Merged

Move config parsing and CRD metrics from apis to internal package #4989

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d0320a
feat: move metrics from apis to internal package
iypetrov Apr 22, 2026
fac5f5c
feat: move config parsing from apis to internal/otelconfig
iypetrov Apr 23, 2026
f4aa85f
feat: move MetricsConfig and Telemetry to the internal/otelconfig
iypetrov May 7, 2026
41beaf0
feat: mv config_test copletely to internal/otelconfig
iypetrov May 7, 2026
178d5cd
fix: lint issues
iypetrov May 7, 2026
6a13c81
Merge branch 'main' into move-otelconfig-and-metrics-to-internal
iypetrov May 10, 2026
8222e29
feat: add changelog entry
iypetrov May 11, 2026
95dfe09
Merge branch 'main' into move-otelconfig-and-metrics-to-internal
iypetrov May 11, 2026
fa6d160
Merge branch 'main' into move-otelconfig-and-metrics-to-internal
iypetrov May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apis/v1alpha1/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/conversion"

"github.com/open-telemetry/opentelemetry-operator/apis/v1beta1"
"github.com/open-telemetry/opentelemetry-operator/internal/otelconfig"
)

var _ conversion.Convertible = &OpenTelemetryCollector{}
Expand Down Expand Up @@ -301,7 +302,7 @@ func tov1alpha1Ports(in []v1beta1.PortsSpec) []PortsSpec {

func tov1alpha1(in v1beta1.OpenTelemetryCollector) (*OpenTelemetryCollector, error) {
c := in.DeepCopy()
configYaml, err := c.Spec.Config.Yaml()
configYaml, err := otelconfig.Yaml(&c.Spec.Config)
if err != nil {
return nil, err
}
Expand Down
Loading
Loading