Move config parsing and CRD metrics from apis to internal package

[iypetrov]

Description:
This a prerequisite for issue #4972, as mention in this comment.

Link to tracking Issue(s):

• Resolves partially: APIs package should not import github.com/goccy/go-yaml #4362

Testing:
No new tests are added, just adapt some of the existing ones.

Breaking changes:

• Methods on *Config (package apis/v1beta1) converted to standalone functions in internal/otelconfig, now taking *v1beta1.Config as the first parameter:
  • GetEnabledComponents, GetReceiverPorts, GetExporterPorts, GetExtensionPorts, GetReceiverAndExporterPorts, GetAllPorts, GetEnvironmentVariables, GetAllRbacRules, ApplyDefaults, GetLivenessProbe, GetReadinessProbe, GetStartupProbe, Yaml, NullObjects
• Methods on *Service converted to functions in internal/otelconfig:
  • MetricsEndpoint, GetTelemetry
  • ApplyDefaults → renamed to ServiceApplyDefaults
• Method on *Telemetry converted to function:
  • ToAnyConfig → renamed to TelemetryToAnyConfig
• Functions moved from apis/v1beta1 to internal/metrics with renames:
  • BootstrapMetrics → Bootstrap
  • NewMetrics(prv, ctx, cl) → New(ctx, prv, cl) (parameter reorder: ctx now first)
• Types moved out of apis/v1beta1:
  • MetricsConfig, Telemetry → internal/otelconfig
  • Metrics → internal/metrics

[swiatekm]

@iypetrov this looks good to me, could you fix the lint errors?

[swiatekm]

Since we're removing symbols from a public package, I think we should add a changelog entry labeling it as breaking. We could move these to a public package, but I'd rather wait and see if anyone complains. WDYT @open-telemetry/operator-maintainers ?

[jaronoff97]

yes, i agree we should definitely mark this breaking, i don't imagine anyone is depending on this, but we should call that out explicitly

[iypetrov]

yes, i agree we should definitely mark this breaking, i don't imagine anyone is depending on this, but we should call that out explicitly

I updated the PR description so to include breaking changes, is that enough?

[swiatekm]

@iypetrov you need to add a changelog entry. Run make chlog-new and fill in the template it creates.

[github-actions]

E2E Test Results

 36 files  259 suites   2h 18m 2s ⏱️
109 tests 109 ✅ 0 💤 0 ❌
281 runs  281 ✅ 0 💤 0 ❌

Results for commit 95dfe09.

♻️ This comment has been updated with latest results.

[iypetrov]

hey @swiatekm, do you think this one is ready to be merged?