Profiling with firepit#3333
Conversation
OTel collector added for profiling with highenend privileges. Send the profiling data to a pyroscope backend. Makefile updated with start-profiling target which starts the demo along with the profiling collector.
Firepit is a opensource tool to view profiles in a flame graph, it doesn't store the profiles. https://github.com/florianl/firepit/tree/main
github-actions
Bot
added
the
helm-update-required
|
Can we utilize collector as a gateway for profiling as for any other signals? |
This shows how you can use the main collector as a gateway for all otel signals
Good shout, we can indeed do this. I have updated the PR. We now send the profiling signal from the ebpf collector to the main collector. |
|
@florianl and @osullivandonal it would be nice to have that in: florianl/firepit#17 I've played locally and with that change we can add Firepit to Envoy and reach it via |
|
I assume here we need to update docs, what is the thoughts here? Should we update the opentelemtry.io demo docs? |
osullivandonal
force-pushed
the
profiling-with-firepit
branch
from
94a2714 to
8e24601
Compare
|
@osullivandonal ive added my changes to your PR. |
|
This is looking good and should be good to go! @osullivandonal back to you 🤓 
|
LGTM: 
|
|
@puckpuck would you give us your blessing? |
|
I'll merge it later today! |
ps48
left a comment
ps48
left a comment
There was a problem hiding this comment.
Nice addition! Profiling is a great signal to have in the demo, and the eBPF collector + Firepit approach keeps things lightweight.
6 participants
Changes
This PR add's profiling to the otel demo and uses firepit as the backend to process and display profiles as a flame graph.
Closes: #1601
To run the demo with profiling:
Profiling
Firepit
Usage
Enable
adHighCpuwith Flagd Configurator....
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.