Add profiling to the otel demo and use pyroscope as the backend#3312
Closed
osullivandonal wants to merge 4 commits into
Closed
Add profiling to the otel demo and use pyroscope as the backend#3312osullivandonal wants to merge 4 commits into
osullivandonal wants to merge 4 commits into
Conversation
OTel collector added for profiling with highenend privileges. Send the profiling data to a pyroscope backend. Makefile updated with start-profiling target which starts the demo along with the profiling collector.
Contributor
Author
|
Closing this PR as #3333 superseeds this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This work add's profiling to the OTel-Demo.
Closes: #1601
OTel collector added for profiling with heightened privileges, this is needed to profiling requiring access to the kernel.
Send the profiling data to a pyroscope backend.
Makefile updated with
start-profilingtarget which starts the demo along with the profiling collector.Note
This work leveraged the documentation from Pyroscope, here.
We can also add this to k8s, this would be done in the helm charts.
Running
You can view profiles via 2 paths:
http://localhost:4040/http://localhost:8080/grafanaProfiling in Grafana
Here we can see an overview of the profiling in Grafana
Ad service High CPU
Here we turn on high CPU for the ad service (feature-flag) and we can use profiling to show us the problem code:
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.