Automated cherry pick of #1836: Synchronize helm clusterrole RBAC with base yaml #1826: Add init containers support to Helm chart #1838: Change icon URL in Chart.yaml #1842: fix: resolve detected data races #1847: fix(ci): upgrade codeql-action to v4 and clean up security #1848: update go dependencies #1844: Extend PodLifeTime with condition, exit code, owner kind,#1850
Merged
Conversation
I noticed in v0.35. ``` E0219 23:53:57.761596 1 reflector.go:204] "Failed to watch" err="failed to list *v1.PersistentVolumeClaim: persistentvolumeclaims is forbidden: User \"system:serviceaccount:kube-system:descheduler\" cannot list resource \"persistentvolumeclaims\" in API group \"\" at the cluster scope" logger="UnhandledError" reflector="k8s.io/client-go/informers/factory.go:161" type="*v1.PersistentVolumeClaim" ``` I saw it in rbac.yaml https://github.com/kubernetes-sigs/descheduler/blob/bec9cd38d01eab2d35f1d76b1b9845649e11bffa/kubernetes/base/rbac.yaml#L38-L40 So I figured this just needed a bump
This commit adds support for init containers in the descheduler Helm chart,
allowing users to run initialization tasks before the main descheduler
container starts.
Changes:
- Add initContainers field to values.yaml with example usage
- Update deployment.yaml template to render init containers
- Update cronjob.yaml template to render init containers
- Bump chart version from 0.34.0 to 0.34.1
Init containers can be used for various purposes such as:
- Pre-loading configuration from external sources
- Waiting for dependencies to be ready
- Setting up required files or permissions
- Running security scans or compliance checks
Example usage in values.yaml:
initContainers:
- name: init-config
image: busybox:1.28
command: ['sh', '-c', 'echo Initializing && sleep 5']
Signed-off-by: kjoshi <kjoshi@egnyte.com>
Updated the icon URL to point to the new logo.
CodeQL Action v1 and v2 have been deprecated. Update upload-sarif to v4, remove unnecessary strategy block (missing required matrix property), and remove invalid exit-code input from the upload-sarif step.
Move container waiting/terminated state checking from PodLifeTime and RemovePodsHavingTooManyRestarts into podutil as separate exported helpers: HasMatchingContainerWaitingState and HasMatchingContainerTerminatedState. Each plugin composes only the helpers it needs.
k8s-ci-robot
added
size/XXL
Contributor
Author
Contributor
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
a7i
deleted the
automated-cherry-pick-of-#1836-#1826-#1838-#1842-#1847-#1848-#1844-upstream-release-1.35
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #1836 #1826 #1838 #1842 #1847 #1848 #1844 on release-1.35.
#1836: Synchronize helm clusterrole RBAC with base yaml
#1826: Add init containers support to Helm chart
#1838: Change icon URL in Chart.yaml
#1842: fix: resolve detected data races
#1847: fix(ci): upgrade codeql-action to v4 and clean up security
#1848: update go dependencies
#1844: Extend PodLifeTime with condition, exit code, owner kind,
For details on the cherry pick process, see the cherry pick requests page.
Preparation for Release 1.35.1