Extend PodLifeTime with condition, exit code, owner kind, and transition time filters by a7i · Pull Request #1844 · kubernetes-sigs/descheduler

a7i · 2026-03-01T22:44:45Z

Description

Extend PodLifeTime with new filtering fields

Adds new fields to PodLifeTimeArgs so it can handle fine-grained, transition-based eviction:

conditions: Filter pods by status.conditions entries (type, status, reason) with an optional minTimeSinceLastTransitionSeconds per condition filter
exitCodes: Filter by container terminated exit codes
ownerKinds: Include or exclude pods by owner reference kind (include/exclude)
states enhanced: Now also checks container terminated reasons (previously only checked waiting reasons)

All non-empty filter categories are ANDed together (a pod must satisfy every specified filter). Within each category, entries are ORed. Pods are processed from oldest to newest based on their creation time. Condition filters, including minTimeSinceLastTransitionSeconds, determine which pods are eligible for eviction but do not affect this ordering.

Extract shared container state matching helpers into podutil

Moves the container waiting/terminated state checking logic from PodLifeTime and RemovePodsHavingTooManyRestarts into podutil as separate exported helpers: HasMatchingContainerWaitingState and HasMatchingContainerTerminatedState. Each plugin composes only the helpers it needs — TooManyRestarts uses only the waiting helper, while PodLifeTime uses both.

Checklist

Copilot

Pull request overview

This PR expands the PodLifeTime descheduler plugin to support transition-based eviction via new filter fields (conditions, exit codes, owner kinds) and then refactors RemoveFailedPods to delegate its eviction behavior to PodLifeTime (via the new NewAs constructor) to reduce duplicated logic.

Changes:

Extend PodLifeTimeArgs with conditions, exitCodes, and ownerKinds, plus enhanced states matching (now includes terminated reasons).
Add delegation support (NewAs) so other plugins (notably RemoveFailedPods) can reuse PodLifeTime logic with additional injected filters.
Add/extend unit tests, e2e tests, and documentation/examples to cover transition-based eviction scenarios.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`test/e2e/e2e_podlifetime_test.go`	Adds e2e coverage for PodLifeTime eviction behavior on failed/succeeded pods with new filters.
`pkg/framework/plugins/removefailedpods/failedpods.go`	Refactors RemoveFailedPods to delegate to PodLifeTime via `NewAs` and maps args.
`pkg/framework/plugins/podlifetime/pod_lifetime.go`	Implements new filters, delegation constructor, and new eviction ordering logic.
`pkg/framework/plugins/podlifetime/types.go`	Adds new config types/fields: `OwnerKinds`, `PodConditionFilter`, `ExitCodes`.
`pkg/framework/plugins/podlifetime/validation.go`	Updates validation rules to account for new filter criteria and ownerKinds.
`pkg/framework/plugins/podlifetime/validation_test.go`	Updates validation test expectations for new validation semantics.
`pkg/framework/plugins/podlifetime/pod_lifetime_test.go`	Adds unit tests for new filtering and ordering behavior.
`pkg/framework/plugins/podlifetime/zz_generated.deepcopy.go`	Updates generated deep-copies for new args/types.
`pkg/framework/plugins/podlifetime/README.md`	Documents the new filters, AND/OR semantics, ordering, and migration notes.
`examples/pod-life-time-transition.yml`	Adds example policy for transition-based eviction.
`README.md`	Updates top-level plugin documentation and examples for PodLifeTime.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

a7i · 2026-03-02T00:59:52Z

/retest-required

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

a7i · 2026-03-02T13:43:48Z

/retest-required

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

a7i · 2026-03-05T02:59:12Z

/cc @jklaw90 @ingvagabund

🙏🏼

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

a7i · 2026-03-06T13:41:23Z

+	if podLifeTimeArgs.MaxPodLifeTimeSeconds != nil {
+		podFilter = podutil.WrapFilterFuncs(podFilter, func(pod *v1.Pod) bool {
+			podAge := metav1.Now().Sub(pod.GetCreationTimestamp().Local())
+			if podAge < 0 {


this is odd, but copilot requested a change for code that I did not touch

ingvagabund · 2026-03-06T15:09:56Z

+	if filter.Reason != "" && cond.Reason != filter.Reason {
+		return false
+	}
+	return true


The case where all fields are unset is validated. So in case someone invokes this without the validation a condition with all fields unset matches every pod? Maybe revert the logic?

Technically only one need to be set so this condition check is still needed

validation:

args.MaxPodLifeTimeSeconds != nil || len(args.States) > 0 || len(args.Conditions) > 0 || len(args.ExitCodes) > 0

ingvagabund · 2026-03-06T15:14:33Z

+					p.Status.Phase = v1.PodFailed
+				}),
+			},
+			expectedEvictedPodCount: 1,


This should not evict a pod if a job is excluded.

isn't p2 a non-Job pod? hence why it's expecting p2 pod to be evicted

I added a separate test to focus on a Job not getting evicted, but this test-case is valid and the assertion is correct

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ion time filters

Move container waiting/terminated state checking from PodLifeTime and RemovePodsHavingTooManyRestarts into podutil as separate exported helpers: HasMatchingContainerWaitingState and HasMatchingContainerTerminatedState. Each plugin composes only the helpers it needs.

ingvagabund · 2026-03-06T19:33:22Z

/hold cancel

ingvagabund · 2026-03-06T19:33:27Z

/approve
/lgtm

k8s-ci-robot · 2026-03-06T19:33:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…#1838-#1842-#1847-#1848-#1844-upstream-release-1.35 Automated cherry pick of #1836: Synchronize helm clusterrole RBAC with base yaml #1826: Add init containers support to Helm chart #1838: Change icon URL in Chart.yaml #1842: fix: resolve detected data races #1847: fix(ci): upgrade codeql-action to v4 and clean up security #1848: update go dependencies #1844: Extend PodLifeTime with condition, exit code, owner kind,

Copilot AI review requested due to automatic review settings March 1, 2026 22:44

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 1, 2026

k8s-ci-robot requested review from JaneLiuL and ricardomaraschini March 1, 2026 22:45

Copilot started reviewing on behalf of a7i March 1, 2026 22:45 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

a7i force-pushed the extend-podlifetime-transitions branch from 2a26912 to e7a230d Compare March 2, 2026 00:28

a7i requested a review from Copilot March 2, 2026 01:24

Copilot started reviewing on behalf of a7i March 2, 2026 01:25 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Comment thread pkg/framework/plugins/podlifetime/pod_lifetime.go

Comment thread pkg/framework/plugins/podlifetime/pod_lifetime_test.go Outdated

Comment thread test/e2e/e2e_podlifetime_test.go Outdated

a7i force-pushed the extend-podlifetime-transitions branch from e7a230d to dff7cb8 Compare March 3, 2026 01:22

Copilot AI review requested due to automatic review settings March 5, 2026 01:24

a7i force-pushed the extend-podlifetime-transitions branch from dff7cb8 to d613ffd Compare March 5, 2026 01:24

Copilot started reviewing on behalf of a7i March 5, 2026 01:25 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

a7i force-pushed the extend-podlifetime-transitions branch from d613ffd to 77d06d2 Compare March 5, 2026 01:32

Copilot AI review requested due to automatic review settings March 5, 2026 01:42

a7i force-pushed the extend-podlifetime-transitions branch from 77d06d2 to 9f3c55a Compare March 5, 2026 01:42

Copilot started reviewing on behalf of a7i March 5, 2026 01:42 View session

a7i force-pushed the extend-podlifetime-transitions branch from 9f3c55a to c4f0ac0 Compare March 5, 2026 01:44

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Comment thread pkg/framework/plugins/podlifetime/pod_lifetime.go

a7i requested a review from Copilot March 5, 2026 01:51

Copilot started reviewing on behalf of a7i March 5, 2026 01:52 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Comment thread README.md

Comment thread README.md

Comment thread examples/pod-life-time-transition.yml

k8s-ci-robot requested review from ingvagabund and jklaw90 March 5, 2026 02:59

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2026

Copilot started reviewing on behalf of a7i March 6, 2026 13:29 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

a7i requested a review from ingvagabund March 6, 2026 13:40

a7i commented Mar 6, 2026

View reviewed changes

a7i changed the title ~~Extend PodLifeTime with transition-based eviction and delegate RemoveFailedPods~~ Extend PodLifeTime with condition, exit code, owner kind, and transition time filters Mar 6, 2026

ingvagabund reviewed Mar 6, 2026

View reviewed changes

Comment thread pkg/framework/plugins/podlifetime/pod_lifetime.go Outdated

a7i force-pushed the extend-podlifetime-transitions branch from 7ef5b0d to 93fc0c5 Compare March 6, 2026 14:36

ingvagabund reviewed Mar 6, 2026

View reviewed changes

Comment thread README.md

Copilot AI review requested due to automatic review settings March 6, 2026 16:31

a7i force-pushed the extend-podlifetime-transitions branch from 93fc0c5 to 7114d0e Compare March 6, 2026 16:31

Copilot started reviewing on behalf of a7i March 6, 2026 16:32 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Comment thread pkg/framework/plugins/podlifetime/pod_lifetime.go Outdated

a7i added 2 commits March 6, 2026 12:17

Extend PodLifeTime with condition, exit code, owner kind, and transit…

a845ed3

…ion time filters

a7i force-pushed the extend-podlifetime-transitions branch from 7114d0e to a4391ea Compare March 6, 2026 17:18

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2026

k8s-ci-robot assigned ingvagabund Mar 6, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026

k8s-ci-robot merged commit 0fafc09 into kubernetes-sigs:master Mar 6, 2026
9 checks passed

a7i deleted the extend-podlifetime-transitions branch March 6, 2026 19:37

This was referenced Apr 6, 2026

Update Helm release descheduler to v0.35.1 claytono/infra#1934

Merged

Update Helm release descheduler to v0.35.1 claytono/infra#1993

Closed

Conversation

a7i commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Extend PodLifeTime with new filtering fields

Extract shared container state matching helpers into podutil

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

a7i commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

a7i commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

a7i commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

a7i Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ingvagabund Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

a7i Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

a7i Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

ingvagabund Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

a7i Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

a7i Mar 6, 2026

a7i commented Mar 1, 2026 •

edited

Loading