Skip to content

Refine runtime detection logic #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
May 18, 2026
+13 −24
Merged

Refine runtime detection logic #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 13 additions & 24 deletions pkg/container/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,38 +15,27 @@ import (
// TODO we can do it as in KIND
var containerRuntime = "docker"

// dockerIsAvailable checks if docker is available in the system
// dockerIsAvailable checks if docker is available and the daemon is running
func dockerIsAvailable() bool {
cmd := kindexec.Command("docker", "-v")
lines, err := kindexec.OutputLines(cmd)
if err != nil || len(lines) != 1 {
return false
}
return strings.HasPrefix(lines[0], "Docker version")
cmd := kindexec.Command("docker", "info")
_, err := kindexec.OutputLines(cmd)
return err == nil
}

func podmanIsAvailable() bool {
cmd := kindexec.Command("podman", "-v")
lines, err := kindexec.OutputLines(cmd)
if err != nil || len(lines) != 1 {
return false
}
return strings.HasPrefix(lines[0], "podman version")
cmd := kindexec.Command("podman", "info")
_, err := kindexec.OutputLines(cmd)
return err == nil
}

func nerdctlIsAvailable() bool {
cmd := kindexec.Command("nerdctl", "-v")
lines, err := kindexec.OutputLines(cmd)
if err != nil || len(lines) != 1 {
// check finch
cmd = kindexec.Command("finch", "-v")
lines, err = kindexec.OutputLines(cmd)
if err != nil || len(lines) != 1 {
return false
}
return strings.HasPrefix(lines[0], "finch version")
cmd := kindexec.Command("nerdctl", "info")
if _, err := kindexec.OutputLines(cmd); err == nil {
return true
}
return strings.HasPrefix(lines[0], "nerdctl version")
cmd = kindexec.Command("finch", "info")
_, err := kindexec.OutputLines(cmd)
return err == nil
}

// Runtime returns the detected container runtime name.
Expand Down
Loading