Refine runtime detection logic#405
Merged
Merged
Conversation
We would have occasional issues trying to do things like use `docker` on a `podman` system. We have the `KIND_EXPERIMENTAL_PROVIDER` override, but that's not always obvious to users. It's also common that users have the `docker` CLI installed, but either as an alias for podman, or for other uses. Our existing logic was to run the "version" command for each runtime client. If the command worked (i.e. the binary was present) then we would assume that was an available runtime. This updates that logic to actually run a command that would require that runtime to be running - `docker info`, etc. If the binary is present but that given runtime is non-functional then we will not incorrectly assume it can be used for our purposes. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would have occasional issues trying to do things like use
dockeron apodmansystem. We have theKIND_EXPERIMENTAL_PROVIDERoverride, but that's not always obvious to users. It's also common that users have thedockerCLI installed, but either as an alias for podman, or for other uses.Our existing logic was to run the "version" command for each runtime client. If the command worked (i.e. the binary was present) then we would assume that was an available runtime.
This updates that logic to actually run a command that would require that runtime to be running -
docker info, etc. If the binary is present but that given runtime is non-functional then we will not incorrectly assume it can be used for our purposes.Related to: #404