Fix ESLint v10 RuleContext API removal (follow-up to #3972)

[ledsun]

This PR follows up on the feedback in the comments of #3972 and incorporates the requested changes.

I think this PR will fix #3977.

[ljharb]

we'll need regression tests - it might be as simple as adding eslint 10 to the GHA matrix.

[codecov]

Codecov Report

❌ Patch coverage is 49.49495% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.26%. Comparing base (9af8845) to head (ea44283).

Files with missing lines	Patch %	Lines
lib/util/eslint.js	21.87%	50 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
+ Coverage   94.76%   97.26%   +2.50%     
==========================================
  Files         134      137       +3     
  Lines       10165    10252      +87     
  Branches     3794     3833      +39     
==========================================
+ Hits         9633     9972     +339     
+ Misses        532      280     -252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[karlnorling]

@ledsun do you have time to address the failing checks. I'm looking at updating to eslint 10 and we're using the eslint-plugin-react

[karlnorling]

What's the status on this PR? Do we need to open another one? Seems we're just waiting for CI to pass? @ljharb ?

[ljharb]

Yes, it needs to be rebased and the test failures fixed. Please do NOT open a redundant PR; if you have changes you want added, comment with a branch or commit link, and I'll pull them in.

[modeitsch]

I checked this from a local checkout of 635cd2ce. It looks like the branch is not behind master anymore:

git rev-list --left-right --count origin/master...HEAD
# 0 2

gh pr checks 3979 --repo jsx-eslint/eslint-plugin-react is also green for the current head, including the ESLint 10 type-check jobs. If GitHub is still showing this as stale/failing somewhere, it may be cached PR metadata rather than an actual rebase/test failure.

[lorand-horvath]

I've pushed some of the commits from this PR to master, but it looks like we're blocked on import-js/eslint-plugin-import#3227.

@ljharb Is it still the case, i.e. blocked on eslint-plugin-import?

[lorand-horvath]

Would it be an option to move to an eslint 10 compatible plugin like eslint-plugin-import-x?

No.

@ljharb Why not? It's not like this one is compatible with eslint 10 or something. When will it be fixed?

[captaindonald]

Yes, it needs to be rebased and the test failures fixed. Please do NOT open a redundant PR; if you have changes you want added, comment with a branch or commit link, and I'll pull them in.

@ljharb I pulled the ESLint 10 RuleTester schema fix out into #4006 — strips ~400 type: references from test files (ESLint 10 dropped type from the error schema) and pins a transitive that's been crashing npm install on node 4/5. Once it merges, rebasing here should leave only a small number of red cells, all of which look like the matrix flakiness tracked in #4007.

[danielhjacobs]

rebasing here should leave only a small number of red cells, all of which look like the matrix flakiness tracked in #4007

Since that PR was merged and so was a PR that closed #4007, can this be rebased? Will that allow this to be merged, or is it also waiting on import-js/eslint-plugin-import#3230 (which needs a new review following rasmi addressing its feedback)?

[captaindonald]

rebasing here should leave only a small number of red cells, all of which look like the matrix flakiness tracked in #4007

Since that PR was merged and so was a PR that closed #4007, can this be rebased? Will that allow this to be merged, or is it also waiting on import-js/eslint-plugin-import#3230 (which needs a new review following rasmi addressing its feedback)?

I rebased and ran some local tests on a fork. I think we are just waiting to get unblocked on [import-js/eslint-plugin-import#3230]. Any remaining cleanup after that should be pretty straight forward.