Pin decorator to avoid license metadata regression#171038
Merged
Merged
Conversation
21 tasks
Contributor
Author
|
This has been raised upstream in decorator by lackas: micheles/decorator#185, so this PR can be closed if the decorator maintainer fixes it first. |
balloob
approved these changes
May 18, 2026
jnimmo
pushed a commit
to jnimmo/core
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Pin
decoratorto5.2.1inhomeassistant/package_constraints.txtand in theCONSTRAINT_BASEsource used byscript/gen_requirements_all.py.decorator==5.3.0is BSD-2-Clause licensed and still shipsLICENSE.txt, but the 5.3.0 wheel no longer exposes the machine-readable license metadata checked byscript/licenses.py(License,License-Expression, or license classifiers). This makes the license audit report it asNone -- None -- [].decorator==5.2.1still exposes the BSD license metadata, so pinning to 5.2.1 avoids the license audit regression without adding a license exception. This constraint can be removed once upstream restores license metadata in a newer release.Validation performed:
ruff check script/gen_requirements_all.pyruff format --check script/gen_requirements_all.pypython -m script.gen_requirements_all validategit diff --checkuv pip compile -c homeassistant/package_constraints.txt requirements.txt requirements_all.txt requirements_test.txt --python-version 3.14resolvesdecorator==5.2.1Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: