Skip to content

Pin decorator to avoid license metadata regression#171038

Merged
balloob merged 1 commit into
home-assistant:devfrom
L0rdCha0s:codex/pin-decorator-521
May 18, 2026
Merged

Pin decorator to avoid license metadata regression#171038
balloob merged 1 commit into
home-assistant:devfrom
L0rdCha0s:codex/pin-decorator-521

Conversation

@L0rdCha0s
Copy link
Copy Markdown
Contributor

Proposed change

Pin decorator to 5.2.1 in homeassistant/package_constraints.txt and in the CONSTRAINT_BASE source used by script/gen_requirements_all.py.

decorator==5.3.0 is BSD-2-Clause licensed and still ships LICENSE.txt, but the 5.3.0 wheel no longer exposes the machine-readable license metadata checked by script/licenses.py (License, License-Expression, or license classifiers). This makes the license audit report it as None -- None -- [].

decorator==5.2.1 still exposes the BSD license metadata, so pinning to 5.2.1 avoids the license audit regression without adding a license exception. This constraint can be removed once upstream restores license metadata in a newer release.

Validation performed:

  • ruff check script/gen_requirements_all.py
  • ruff format --check script/gen_requirements_all.py
  • python -m script.gen_requirements_all validate
  • git diff --check
  • verified uv pip compile -c homeassistant/package_constraints.txt requirements.txt requirements_all.txt requirements_test.txt --python-version 3.14 resolves decorator==5.2.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: n/a
  • This PR is related to issue: n/a
  • Link to documentation pull request: n/a
  • Link to developer documentation pull request: n/a
  • Link to frontend pull request: n/a

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 17, 2026 21:51
@home-assistant home-assistant Bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels May 17, 2026
@L0rdCha0s
Copy link
Copy Markdown
Contributor Author

This has been raised upstream in decorator by lackas: micheles/decorator#185, so this PR can be closed if the decorator maintainer fixes it first.

@L0rdCha0s L0rdCha0s marked this pull request as ready for review May 17, 2026 22:00
@L0rdCha0s L0rdCha0s requested a review from a team as a code owner May 17, 2026 22:00
@balloob balloob merged commit 2fcfa83 into home-assistant:dev May 18, 2026
48 checks passed
jnimmo pushed a commit to jnimmo/core that referenced this pull request May 18, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants