Add decorator to license exceptions#171031
Conversation
|
We should not add an exception for new dependencies or updates. It should be fixed in the dependency before we adopt it, or we can't adopt it. |
..Understood. To be clear: my PR didn't change this: CI picks this new version up automatically, so CI is currently broken for any PR that adds a dependency and triggers a full build in CI. |
|
Ah shoot. That sucks. We should report an issue upstream and pin a lower version for now. |
|
Superseded by #171038, which pins decorator to 5.2.1 in constraints instead of adding a license exception. |
|
To be fair, we've added exceptions for dependencies like this before |
|
Your choice ultimately! I guess it depends on how responsive the maintainer of 'decorator' is.. if he adds the license, both this and #171038 become superfluous. |
|
I think it's better to pin it so we avoid another CI failure when the package is fixed. Then we can handle it in our own time. |
Yep - @balloob has now merged my alternate PR that does exactly that. |
Proposed change
Add
decoratorto the license audit exceptions.decorator==5.3.0is BSD-2-Clause licensed and shipsLICENSE.txt, but the 5.3.0 wheel no longer exposes machine-readable license metadata (License,License-Expression, or license classifiers). The license audit therefore reports it asNone -- None -- [].Earlier
decorator==5.2.1wheels exposedLicense: BSD-2-ClauseandLicense :: OSI Approved :: BSD License, so this started failing after the 5.3.0 release.Validation performed:
ruff check script/licenses.pyruff format --check script/licenses.pygit diff --checkdecorator==5.3.0package definition is not metadata-approved but is covered by the exceptionType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: