case-wrap raise* helpers for strictCaseObjects#60
Open
aryonoco wants to merge 1 commit into
Open
Conversation
Rewrite raiseResultOk and raiseResultError to dispatch on
oResultPrivate via `case`, avoiding {.cast(uncheckedAssign).}
(which does not suppress read-side strict checks and is unavailable
on Nim < 1.6). The `when E is void` branch of raiseResultError is
hoisted above the new case so the non-void body does not
instantiate on the void specialisation, where eResultPrivate does
not exist.
The unreachable-by-contract fallback branches raise
ResultError[void] to satisfy {.noreturn.}; this matches the type
raised by adjacent reachable branches and avoids a forward
reference to raiseResultDefect.
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites `raiseResultOk` and `raiseResultError` to dispatch on `oResultPrivate` via `case`, avoiding `{.cast(uncheckedAssign).}` (which does not suppress read-side strict checks and is unavailable on Nim < 1.6). The `when E is void` branch of `raiseResultError` is hoisted above the new case to keep the non-void body from instantiating on the void specialisation (where `eResultPrivate` does not exist).
The unreachable-by-contract fallback branches raise `ResultError[void]` to satisfy `{.noreturn.}`; this matches the type raised by adjacent reachable branches and avoids a forward reference to `raiseResultDefect`.