add strictCaseObjects test coverage#62
Draft
aryonoco wants to merge 1 commit into
Draft
Conversation
Adds tests/test_strict_caseobjects.nim — a compile + runtime check
that every accessor, combinator, equality, and exception-bridge path
through Result compiles and behaves identically under
`{.experimental: "strictCaseObjects".}` as it does without the pragma.
Thirteen sections cover the four specialisations
(Result[T, E] / Opt[T] / Result[void, E] / Result[void, void]) and
the exception-bridge surface of `tryValue`: ref Exception (including
the nil-payload case produced by `Result.default()`), user-defined
`toException`, and the opaque-E fallback. `mapCastErr` gets a
dedicated block with a same-representation source/target pair since
`cast[E1]` requires it.
The nimble `test` task runs the new file under both `c` and
`--mm:refc` on Nim >= 2.0. The pragma exists on earlier Nim but the
flow-analysis diagnostics this test exercises are only stabilised on
modern Nim, so older runs are not affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — depends on #59, #60, #61. This file's assertions exercise the strictCaseObjects-safe code paths introduced by those PRs; its CI will go green once they merge and this branch is rebased onto the merged tip.
Adds `tests/test_strict_caseobjects.nim` — a compile + runtime check that every accessor, combinator, equality, and exception-bridge path through `Result` compiles and behaves identically under `{.experimental: "strictCaseObjects".}` as it does without the pragma.
Thirteen blocks cover the four specialisations (`Result[T, E]`, `Opt[T]`, `Result[void, E]`, `Result[void, void]`) and the exception-bridge surface of `tryValue`: `ref Exception` (including the nil-payload case produced by `Result.default()`), user-defined `toException`, and the opaque-E fallback. `mapCastErr` gets a dedicated block with a same-representation source/target pair (`int32` / `uint32`) since `cast[E1]` requires matching runtime shape.
The nimble `test` task runs the new file under both `c` and `--mm:refc` on Nim >= 2.0. The pragma exists on earlier Nim but the flow-analysis diagnostics this test exercises are only stabilised on modern Nim, so older runs are unaffected.