Update PR comment behavior for on-failure mode#941
Conversation
When comment_summary_in_pr is set to 'on-failure', the action now updates existing comments when issues are resolved in subsequent runs, providing clear feedback that dependency issues have been fixed.
fb6f77d to
f21eb50
Compare
|
Hey @dangoor 👋 , any chance I could get a review 👀 on this? |
|
👋 This pull request has been marked as stale because it has been open with no activity for 180 days. You can: comment on the PR or remove the stale label to hold stalebot off for a while, add the |
|
This is still very important to me! |
|
@niebloomj unfortunately this PR has merge conflicts (there's a dev planning to make a release soon, so if you rebase maybe they'd be able to merge...) |
|
@sgmurphy I opened sgmurphy#3 in your fork to resolve the merge conflicts against current |
Resolve merge conflicts with actions/main
|
Thanks for the PR @niebloomj! I think this PR is ready for review again. |
|
@ahpook ? |
Summary
on-failuremode to update existing comments when issues are resolvedChanges
comment-pr.tsto handle success cases in on-failure mode by updating existing commentshasExistingCommenthelper function to check for existing dependency review commentsTest plan
Demo
Live demonstration of the enhanced functionality:
Demo 1: Enhanced
on-failuremode behaviorsgmurphy/fictional-garbanzo#1
on-failuremodeDemo 2:
nevermode validationsgmurphy/fictional-garbanzo#2
comment-summary-in-pr: neverproperly suppresses all comments