Skip to content

docs(docs): record 0011 PR 2.4 + 2.5 (DataState adoption) progress#1710

Closed
Skords-01 wants to merge 1 commit into
mainfrom
devin/1777905682-0011-progress
Closed

docs(docs): record 0011 PR 2.4 + 2.5 (DataState adoption) progress#1710
Skords-01 wants to merge 1 commit into
mainfrom
devin/1777905682-0011-progress

Conversation

@Skords-01
Copy link
Copy Markdown
Owner

@Skords-01 Skords-01 commented May 4, 2026

Summary

Doc-only оновлення docs/initiatives/0011-foundation-adoption-and-process-discipline.md: фіксує прогрес по PR 2.4 (#1703) і PR 2.5 (#1709) — DataState consumer adoption у finyk + fizruk модулях.

  • Оновлено Status: header: «Phase 1 ~70% done; Phase 2 in flight (2.2 merged; 2.4 + 2.5 opened 2026-05-04)».
  • У таблиці DataState consumer migrations замінено початкові спекулятивні приклади файлів на actual landed targets:
  • Додано footnote, що пояснює: початкові приклади (MonoTransactionsPanel, BudgetPanel, MonoAccountsList, WorkoutHistoryPanel, BiometricsPanel) — directional; фізичних компонентів з такими іменами в репі немає. Що мігрували насправді — це surface area з Skeleton-based first-paint guard-ами (if (loadingTx && realTx.length === 0) і view === "log" && !workoutsLoaded).

Жодних коду / скоупу / процесних змін — лише progress record.

Governing Skill

  • Primary skill: sergeant-review-and-merge (governance / docs freshness).
  • Secondary skill (if truly needed): n/a.

Playbook

  • Primary playbook: docs/playbooks/initiative-progress-update.md (якщо існує) / docs/governance/review-checklist.md.
  • Why this playbook: doc-only оновлення статусу ініціативи; має проходити стандартний review checklist.
  • If no playbook matched, why: можливо немає окремого playbook для doc-only оновлень — застосовуємо governance review checklist.

Verification

git diff --merge-base origin/main -- docs/initiatives/0011-foundation-adoption-and-process-discipline.md

Локально:

Additional checks:

  • Local smoke / manual validation completed (read-through, markdown render).
  • Surface-specific checks completed (jсон-таблиця в новому форматі без зламу попередніх стовбців; інші розділи — без змін).

Docs and Governance

  • I updated docs that changed with the behavior, contract, workflow, or rollout.
  • I checked whether AGENTS.md needed an update.
  • I checked whether a playbook or skill needed an update.
  • I checked whether governance docs or review docs needed an update.

Updated docs:

  • docs/initiatives/0011-foundation-adoption-and-process-discipline.md (status header + Phase 2 table + footnote).

AGENTS.md / playbooks / governance / review-checklist — без змін: цей PR — суто progress record для початково-визначеного скоупу 0011.

Risk and Rollout

Hard Rule #15

  • I read AGENTS.md before coding.
  • Internal docs I touched are in Ukrainian.
  • I did not use --no-verify.

Reviewer Notes


Summary by cubic

Docs-only update to the 0011 initiative to record progress for PR 2.4 (#1703) and PR 2.5 (#1709) adopting DataState in finyk and fizruk.
Updates the status header, swaps speculative examples for actual file targets (Overview.tsx, budgets/Budgets.tsx, transactions/TransactionList.tsx, TransactionList.test.tsx, pages/Workouts.tsx), and adds a note explaining the original file names were placeholders.

Written for commit c8dc65e. Summary will update on new commits.

- Update 0011 status header: Phase 1 ~70% done, Phase 2 in flight
  (2.2 merged; 2.4 and 2.5 opened 2026-05-04).
- Replace the original speculative example file list for 2.4/2.5
  in the migration table with the actual files we landed:
  - 2.4: Overview.tsx, budgets/Budgets.tsx,
    transactions/TransactionList.tsx + new TransactionList.test.tsx
    (#1703).
  - 2.5: pages/Workouts.tsx -- the only Skeleton-based loading
    site in the fizruk module (#1709). The rest of fizruk pages
    work synchronously over local-first MMKV-web data and are
    intentionally left outside DataState.
- Add a footnote explaining that the original example components
  (MonoTransactionsPanel, BudgetPanel, MonoAccountsList,
  WorkoutHistoryPanel, BiometricsPanel) were directional --
  no physical components with those names exist in the repo;
  what we actually migrated is the matching pattern at the
  surface area where Skeleton-based first-paint guards live.

No code or scope changes. Doc-only progress record.
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sergeant Ready Ready Preview, Comment May 4, 2026 2:42pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@Skords-01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 46 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f115a9ec-59c8-41a1-b117-d12bd9ba1083

📥 Commits

Reviewing files that changed from the base of the PR and between fbd4e36 and c8dc65e.

📒 Files selected for processing (1)
  • docs/initiatives/0011-foundation-adoption-and-process-discipline.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1777905682-0011-progress

Review rate limit: 0/10 reviews remaining, refill in 3 minutes and 46 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Skords-01
Copy link
Copy Markdown
Owner Author

Closing in favor of #1715 — combined doc PR for 2.4 + 2.5 + 2.6 + 2.7 (<DataState> adoption progress). #1710 had TL;DR-section conflicts with main after mid-day round-7 doc updates landed; #1715 is rebased on the current main and records all four consumer PRs in one entry.

@Skords-01 Skords-01 closed this May 4, 2026
Skords-01 pushed a commit that referenced this pull request May 4, 2026
Update initiative 0011 to reflect Phase 2 progress through 2026-05-04:

- Status header bumped to include the four open <DataState> consumer
  PRs: 2.4 #1703 (finyk), 2.5 #1709 (fizruk), 2.6 #1713 (nutrition),
  2.7 #1714 (routine). Last-validated handle aligned with the actual
  initiative owner (@Skords-01).
- Phase 2 table column 'Файли (приклад)' renamed to 'Файли (фактичні
  споживачі)' and ETA column replaced with Status (PR-link). Rows for
  2.4–2.7 now point at the actual landed targets, not the initial
  guess names from the proposal draft (MonoTransactionsPanel,
  WorkoutHistoryPanel, NutritionMealsPanel, RoutineList, etc. — none
  of those components physically exist in the repo).
- New explanatory note after the table records why the file list
  diverged from the original draft (real Skeleton-based loading sites
  per module) and documents the per-module finding for 2.6 / 2.7
  (NutritionApp.tsx Menu plan branch; RoutineTimeline.tsx calendar
  branch — both modules have exactly one consumer of
  @shared/components/ui/Skeleton).

Supersedes #1710 (single doc PR for 2.4 + 2.5 only); this combined
update is the cleaner record because all four <DataState> consumer
adoption PRs landed on the same day.

Closes the doc-side of initiative 0011 PR 2.6 + 2.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant