Skip to content

docs(docs): record 0011 PR 2.4 + 2.5 + 2.6 + 2.7 (DataState adoption) progress#1715

Merged
Skords-01 merged 1 commit into
mainfrom
devin/1777913150-0011-progress-2-6-2-7
May 4, 2026
Merged

docs(docs): record 0011 PR 2.4 + 2.5 + 2.6 + 2.7 (DataState adoption) progress#1715
Skords-01 merged 1 commit into
mainfrom
devin/1777913150-0011-progress-2-6-2-7

Conversation

@Skords-01
Copy link
Copy Markdown
Owner

@Skords-01 Skords-01 commented May 4, 2026

Summary

Update docs/initiatives/0011-foundation-adoption-and-process-discipline.md to reflect Phase 2 progress as of 2026-05-04 — all four <DataState> consumer-adoption PRs are now open:

  • PR 2.4 — finyk Mono panels — #1703
  • PR 2.5 — fizruk Workouts journal — #1709
  • PR 2.6 — nutrition panels — #1713
  • PR 2.7 — routine panels — #1714

Changes:

  1. Status header bumped: ProposedPhase 1 ~70% done; Phase 2 in flight (2.4 + 2.5 + 2.6 + 2.7 opened 2026-05-04). Last-validated handle aligned with the actual initiative owner (@Skords-01).
  2. Phase 2 table — column "Файли (приклад)" renamed to "Файли (фактичні споживачі)" and ETA column replaced with Status carrying the PR link. Rows 2.4–2.7 now reference actual landed targets, not the initial guess names from the proposal (MonoTransactionsPanel, WorkoutHistoryPanel, NutritionMealsPanel, RoutineList, etc. — none of those components exist in the repo).
  3. New explanatory note after the table documents the per-module finding for 2.6 / 2.7: nutrition has exactly one Skeleton-importer (NutritionApp.tsx Menu "plan" branch), routine has exactly one (RoutineTimeline.tsx calendar branch). Food-search dropdown (nutrition useFoodSearch) is intentionally excluded — inline list-state, not panel-level skeleton swap.

Supersedes #1710 (single doc PR for 2.4 + 2.5 only). #1710 was opened earlier today, has TL;DR-section conflicts with main (mid-day round-7 doc updates landed in between), and is unmergeable. This combined PR is the cleaner record because all four <DataState> adoption PRs landed on the same day. Recommend closing #1710 in favor of this PR.

Governing Skill

  • Primary skill: sergeant-review-and-merge (initiative-doc upkeep)
  • Secondary skill (if truly needed): n/a — pure governance update.

Playbook

  • Primary playbook: n/a — initiative progress recording, not a feature ship.
  • Why this playbook: docs/initiatives/** updates do not have a dedicated playbook; the convention is "amend the initiative doc on each PR landing burst" (mirrors initiative 0009 progress-tracking workflow).
  • If no playbook matched, why: this is doc-only progress recording with no code or process change.

Verification

# Doc lint via prettier formatting (auto-applied):
pnpm prettier --write docs/initiatives/0011-foundation-adoption-and-process-discipline.md

# Markdown link integrity (relative to existing doc cross-refs — no new links beyond PR numbers):
git diff --check

Results:

  • Prettier formatted clean (markdown table widths preserved by Prettier's prose-wrap: preserve policy).
  • No additional repo touch points; doc-only change to a single file (docs/initiatives/0011-foundation-adoption-and-process-discipline.md).

Additional checks:

  • Local smoke / manual validation completed
  • Surface-specific checks completed

Docs and Governance

  • I updated docs that changed with the behavior, contract, workflow, or rollout.
  • I checked whether AGENTS.md needed an update.
  • I checked whether a playbook or skill needed an update.
  • I checked whether governance docs or review docs needed an update.

Updated docs:

  • docs/initiatives/0011-foundation-adoption-and-process-discipline.md — Status header + Phase 2 table + explanatory footnote.

Risk and Rollout

  • User-visible risk: none. Doc-only change; no code, no migrations, no env, no config.
  • Rollout / deploy order: ship as-is on merge. No production effect.
  • Backout plan: revert this PR; standalone doc update with no follow-up dependents.

Hard Rule #15

  • I read AGENTS.md before coding.
  • Internal docs I touched are in Ukrainian.
  • I did not use --no-verify.

Reviewer Notes


Summary by cubic

Update docs/initiatives/0011-foundation-adoption-and-process-discipline.md to record Phase 2 progress: status header bumped, owner aligned to @Skords-01, and the Phase 2 table now links to the open <DataState> adoption PRs 2.4–2.7 with the actual consumer files. Added a short note explaining why names differ from the proposal and documenting the single @shared/components/ui/Skeleton consumers for nutrition (NutritionApp.tsx Menu "plan") and routine (RoutineTimeline.tsx calendar); the food-search dropdown is out of scope.

Written for commit 96b9013. Summary will update on new commits.

Summary by CodeRabbit

  • Documentation
    • Updated initiative documentation with progress tracking information, reflecting Phase 1 advancement (~70% complete) and Phase 2 ongoing development activities.

Update initiative 0011 to reflect Phase 2 progress through 2026-05-04:

- Status header bumped to include the four open <DataState> consumer
  PRs: 2.4 #1703 (finyk), 2.5 #1709 (fizruk), 2.6 #1713 (nutrition),
  2.7 #1714 (routine). Last-validated handle aligned with the actual
  initiative owner (@Skords-01).
- Phase 2 table column 'Файли (приклад)' renamed to 'Файли (фактичні
  споживачі)' and ETA column replaced with Status (PR-link). Rows for
  2.4–2.7 now point at the actual landed targets, not the initial
  guess names from the proposal draft (MonoTransactionsPanel,
  WorkoutHistoryPanel, NutritionMealsPanel, RoutineList, etc. — none
  of those components physically exist in the repo).
- New explanatory note after the table records why the file list
  diverged from the original draft (real Skeleton-based loading sites
  per module) and documents the per-module finding for 2.6 / 2.7
  (NutritionApp.tsx Menu plan branch; RoutineTimeline.tsx calendar
  branch — both modules have exactly one consumer of
  @shared/components/ui/Skeleton).

Supersedes #1710 (single doc PR for 2.4 + 2.5 only); this combined
update is the cleaner record because all four <DataState> consumer
adoption PRs landed on the same day.

Closes the doc-side of initiative 0011 PR 2.6 + 2.7.
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sergeant Ready Ready Preview, Comment May 4, 2026 4:48pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

📝 Walkthrough

Walkthrough

A documentation update to an initiative tracking document. The header metadata is refreshed: the last validator is changed to a new owner, and the status transitions from a proposed phase schedule to a concrete progress report with Phase 1 approximately 70% complete and Phase 2 active.

Changes

Initiative Status Update

Layer / File(s) Summary
Metadata & Progress Report
docs/initiatives/0011-foundation-adoption-and-process-discipline.md
Initiative header updated: author changed and status transitioned from "Proposed" to in-flight progress report with Phase 1 at ~70% completion and Phase 2 marked active with referenced PRs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

size/XS

Poem

🐰 The initiative hops along with pride,
New ownership and progress far and wide,
Phase One's nearly done, phase two takes flight,
The roadmap glimmers ever bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly relates to the main change: updating the 0011 initiative document to record progress on Phase 2 PRs (2.4, 2.5, 2.6, 2.7) for DataState adoption, which is exactly what the changeset accomplishes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1777913150-0011-progress-2-6-2-7

Review rate limit: 7/10 reviews remaining, refill in 12 minutes and 27 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/S label May 4, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/initiatives/0011-foundation-adoption-and-process-discipline.md`:
- Around line 3-4: Replace the prose on the "Status:" field (the line beginning
with "Status:") with a lifecycle badge using one of the allowed values (Active,
Scaffolded, Deprecated, Archived) per the docs conventions (e.g., "Status:
Active" as the badge), and move the detailed progress prose currently on that
line into a new "Progress" or "Notes" section in the document body so the
detailed update remains but the Status field is machine-readable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dedb0d24-0ae1-4e8d-847b-9c8e8629b68d

📥 Commits

Reviewing files that changed from the base of the PR and between 3097207 and 96b9013.

📒 Files selected for processing (1)
  • docs/initiatives/0011-foundation-adoption-and-process-discipline.md

Comment on lines +3 to +4
> **Last validated:** 2026-05-04 by @Skords-01. **Next review:** 2026-08-02.
> **Status:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (#1696); 2.4 (#1703) + 2.5 (#1709) + 2.6 (#1713) + 2.7 (#1714) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine; 2.8 HubChat/coach/digest залишається).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Status field must use a lifecycle badge per coding guidelines.

Line 4 contains detailed progress prose instead of the required status badge. As per coding guidelines, docs/**/*.md files must "declare status (Active, Scaffolded, Deprecated, Archived) in a status badge under the freshness marker."

The detailed progress information is valuable but should be moved to a separate field or the document body. The Status field should use one of the four allowed lifecycle values.

📋 Proposed fix to comply with guidelines
 > **Last validated:** 2026-05-04 by `@Skords-01`. **Next review:** 2026-08-02.
-> **Status:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (`#1696`); 2.4 (`#1703`) + 2.5 (`#1709`) + 2.6 (`#1713`) + 2.7 (`#1714`) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine; 2.8 HubChat/coach/digest залишається).
+> **Status:** Active
+> **Progress:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (`#1696`); 2.4 (`#1703`) + 2.5 (`#1709`) + 2.6 (`#1713`) + 2.7 (`#1714`) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine; 2.8 HubChat/coach/digest залишається).

As per coding guidelines, the status badge pattern enables automation and maintains consistency across documentation files.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/initiatives/0011-foundation-adoption-and-process-discipline.md` around
lines 3 - 4, Replace the prose on the "Status:" field (the line beginning with
"Status:") with a lifecycle badge using one of the allowed values (Active,
Scaffolded, Deprecated, Archived) per the docs conventions (e.g., "Status:
Active" as the badge), and move the detailed progress prose currently on that
line into a new "Progress" or "Notes" section in the document body so the
detailed update remains but the Status field is machine-readable.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

⏱️ CI Pipeline Duration Report

Based on the last 50 successful runs on the default branch.

Overall Pipeline

Metric Value
p50 6m 26s
p95 7m 55s
p99 9m 3s
Current run 6m 10s
vs p95 -22.1%

Trend (last 20 runs): ▃▃▁▂▃▃▃▂▃▃▂▂▄▃▃▆▅▄█▆

Per-Job Breakdown

Job p50 p95 p99 Current vs p95
Accessibility (axe-core) 2m 5s 2m 21s 2m 23s 0s -100.0%
Commit messages (commitlint) 0s 0s 0s 33s N/A
Critical-flow E2E (Playwright) 1m 36s 1m 44s 1m 44s 5m 59s +245.2%
Migration lint (AGENTS rule 0s 0s 0s 6s N/A
Pipeline duration (p95 trend) 26s 27s 27s
Secret scan (gitleaks) 8s 11s 11s 8s -27.3%
Smoke E2E (Playwright) 1m 26s 1m 40s 1m 40s
Test coverage (vitest) 2m 4s 2m 33s 2m 33s 1m 56s -24.2%
Workflow lint (actionlint) 7s 7s 7s 6s -14.3%
check 4m 12s 4m 54s 5m 6s 51s -82.7%
tsconfig strict guard (PR-1.A) 5s 14s 14s 9s -35.7%

@Skords-01 Skords-01 merged commit 7b144f9 into main May 4, 2026
34 of 48 checks passed
@Skords-01 Skords-01 deleted the devin/1777913150-0011-progress-2-6-2-7 branch May 4, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants