docs(docs): record 0011 PR 2.4 + 2.5 + 2.6 + 2.7 (DataState adoption) progress#1715
Conversation
Update initiative 0011 to reflect Phase 2 progress through 2026-05-04: - Status header bumped to include the four open <DataState> consumer PRs: 2.4 #1703 (finyk), 2.5 #1709 (fizruk), 2.6 #1713 (nutrition), 2.7 #1714 (routine). Last-validated handle aligned with the actual initiative owner (@Skords-01). - Phase 2 table column 'Файли (приклад)' renamed to 'Файли (фактичні споживачі)' and ETA column replaced with Status (PR-link). Rows for 2.4–2.7 now point at the actual landed targets, not the initial guess names from the proposal draft (MonoTransactionsPanel, WorkoutHistoryPanel, NutritionMealsPanel, RoutineList, etc. — none of those components physically exist in the repo). - New explanatory note after the table records why the file list diverged from the original draft (real Skeleton-based loading sites per module) and documents the per-module finding for 2.6 / 2.7 (NutritionApp.tsx Menu plan branch; RoutineTimeline.tsx calendar branch — both modules have exactly one consumer of @shared/components/ui/Skeleton). Supersedes #1710 (single doc PR for 2.4 + 2.5 only); this combined update is the cleaner record because all four <DataState> consumer adoption PRs landed on the same day. Closes the doc-side of initiative 0011 PR 2.6 + 2.7.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughA documentation update to an initiative tracking document. The header metadata is refreshed: the last validator is changed to a new owner, and the status transitions from a proposed phase schedule to a concrete progress report with Phase 1 approximately 70% complete and Phase 2 active. ChangesInitiative Status Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 7/10 reviews remaining, refill in 12 minutes and 27 seconds. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/initiatives/0011-foundation-adoption-and-process-discipline.md`:
- Around line 3-4: Replace the prose on the "Status:" field (the line beginning
with "Status:") with a lifecycle badge using one of the allowed values (Active,
Scaffolded, Deprecated, Archived) per the docs conventions (e.g., "Status:
Active" as the badge), and move the detailed progress prose currently on that
line into a new "Progress" or "Notes" section in the document body so the
detailed update remains but the Status field is machine-readable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: dedb0d24-0ae1-4e8d-847b-9c8e8629b68d
📒 Files selected for processing (1)
docs/initiatives/0011-foundation-adoption-and-process-discipline.md
| > **Last validated:** 2026-05-04 by @Skords-01. **Next review:** 2026-08-02. | ||
| > **Status:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (#1696); 2.4 (#1703) + 2.5 (#1709) + 2.6 (#1713) + 2.7 (#1714) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine; 2.8 HubChat/coach/digest залишається). |
There was a problem hiding this comment.
Status field must use a lifecycle badge per coding guidelines.
Line 4 contains detailed progress prose instead of the required status badge. As per coding guidelines, docs/**/*.md files must "declare status (Active, Scaffolded, Deprecated, Archived) in a status badge under the freshness marker."
The detailed progress information is valuable but should be moved to a separate field or the document body. The Status field should use one of the four allowed lifecycle values.
📋 Proposed fix to comply with guidelines
> **Last validated:** 2026-05-04 by `@Skords-01`. **Next review:** 2026-08-02.
-> **Status:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (`#1696`); 2.4 (`#1703`) + 2.5 (`#1709`) + 2.6 (`#1713`) + 2.7 (`#1714`) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine; 2.8 HubChat/coach/digest залишається).
+> **Status:** Active
+> **Progress:** Phase 1 ~70% done (1.1/1.2/1.3 merged; 1.4 pending). Phase 2 in flight: 2.2 merged (`#1696`); 2.4 (`#1703`) + 2.5 (`#1709`) + 2.6 (`#1713`) + 2.7 (`#1714`) opened 2026-05-04 (DataState consumer adoption — finyk + fizruk + nutrition + routine; 2.8 HubChat/coach/digest залишається).As per coding guidelines, the status badge pattern enables automation and maintains consistency across documentation files.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/initiatives/0011-foundation-adoption-and-process-discipline.md` around
lines 3 - 4, Replace the prose on the "Status:" field (the line beginning with
"Status:") with a lifecycle badge using one of the allowed values (Active,
Scaffolded, Deprecated, Archived) per the docs conventions (e.g., "Status:
Active" as the badge), and move the detailed progress prose currently on that
line into a new "Progress" or "Notes" section in the document body so the
detailed update remains but the Status field is machine-readable.
⏱️ CI Pipeline Duration ReportBased on the last 50 successful runs on the default branch. Overall Pipeline
Trend (last 20 runs): Per-Job Breakdown
|
Summary
Update
docs/initiatives/0011-foundation-adoption-and-process-discipline.mdto reflect Phase 2 progress as of 2026-05-04 — all four<DataState>consumer-adoption PRs are now open:Changes:
Proposed→Phase 1 ~70% done; Phase 2 in flight (2.4 + 2.5 + 2.6 + 2.7 opened 2026-05-04). Last-validated handle aligned with the actual initiative owner (@Skords-01).MonoTransactionsPanel,WorkoutHistoryPanel,NutritionMealsPanel,RoutineList, etc. — none of those components exist in the repo).NutritionApp.tsxMenu "plan" branch), routine has exactly one (RoutineTimeline.tsxcalendar branch). Food-search dropdown (nutritionuseFoodSearch) is intentionally excluded — inline list-state, not panel-level skeleton swap.Supersedes #1710 (single doc PR for 2.4 + 2.5 only). #1710 was opened earlier today, has TL;DR-section conflicts with
main(mid-day round-7 doc updates landed in between), and is unmergeable. This combined PR is the cleaner record because all four<DataState>adoption PRs landed on the same day. Recommend closing #1710 in favor of this PR.Governing Skill
sergeant-review-and-merge(initiative-doc upkeep)Playbook
docs/initiatives/**updates do not have a dedicated playbook; the convention is "amend the initiative doc on each PR landing burst" (mirrors initiative 0009 progress-tracking workflow).Verification
Results:
prose-wrap: preservepolicy).docs/initiatives/0011-foundation-adoption-and-process-discipline.md).Additional checks:
Docs and Governance
AGENTS.mdneeded an update.Updated docs:
docs/initiatives/0011-foundation-adoption-and-process-discipline.md— Status header + Phase 2 table + explanatory footnote.Risk and Rollout
Hard Rule #15
AGENTS.mdbefore coding.--no-verify.Reviewer Notes
main(markdown link checker, governance sync, serverapiV1.test.ts, mobilevite buildagainst@sergeant/db-schema/sqlite, Argos visual regression) are unrelated to this change — observed identically on PR 2.4–2.7.Summary by cubic
Update
docs/initiatives/0011-foundation-adoption-and-process-discipline.mdto record Phase 2 progress: status header bumped, owner aligned to@Skords-01, and the Phase 2 table now links to the open<DataState>adoption PRs 2.4–2.7 with the actual consumer files. Added a short note explaining why names differ from the proposal and documenting the single@shared/components/ui/Skeletonconsumers for nutrition (NutritionApp.tsxMenu "plan") and routine (RoutineTimeline.tsxcalendar); the food-search dropdown is out of scope.Written for commit 96b9013. Summary will update on new commits.
Summary by CodeRabbit