Fix SHAKE with STM32MP13 and add simulator#10494
Open
LinuxJedi wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables SHAKE builds on STM32 targets when STM32_HASH_SHA3 is enabled by selectively compiling the software Keccak primitives alongside the STM32 SHA-3 hardware backend, and expands CI coverage by adding an STM32MP135 simulator run.
Changes:
- Add
WC_SHA3_SW_KECCAKgating so software Keccak primitives can be compiled when STM32 SHA-3 hardware acceleration is enabled but SHAKE is also enabled. - Update SHA-3 software-implementation preprocessor guards to use
WC_SHA3_SW_KECCAK. - Extend the STM32 simulator GitHub Actions workflow matrix to include STM32MP135 and temporarily patch simulator firmware settings to enable SHAKE.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
wolfcrypt/src/sha3.c |
Introduces WC_SHA3_SW_KECCAK and switches software Keccak compilation guards to allow SHAKE-on-software with STM32 SHA-3 HW enabled. |
.github/workflows/stm32-sim.yml |
Adds STM32MP135 to the simulator CI matrix and applies a temporary firmware settings patch to exercise SHAKE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This fixes the fact that you can't compile SHAKE when SHA-3 hardware acceleration is enabled for STM32. It also adds the STM32MP13 emulator with hardware support from the simulators repo.
LinuxJedi
force-pushed
the
STM32MP13-SHAKE
branch
from
d15d243 to
ecdf170
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the fact that you can't compile SHAKE when SHA-3 hardware acceleration is enabled for STM32. It also adds the STM32MP13 emulator with hardware support from the simulators repo.