Skip to content

fix: prevent the conv list from reloading when navigating back from a message screen [WPB-8645]#4827

Closed
MohamadJaara wants to merge 1 commit into
developfrom
mo/fix/conv-screan-reloading-when-navigating
Closed

fix: prevent the conv list from reloading when navigating back from a message screen [WPB-8645]#4827
MohamadJaara wants to merge 1 commit into
developfrom
mo/fix/conv-screan-reloading-when-navigating

Conversation

@MohamadJaara
Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara commented May 18, 2026

https://wearezeta.atlassian.net/browse/WPB-8645


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

prevent the conv list from reloading when navigating back from a message screen

Solutions

set collectAsLazyPagingItemsWithLifecycle minActiveState to STARTED

@MohamadJaara MohamadJaara force-pushed the mo/fix/conv-screan-reloading-when-navigating branch from 7fb7f20 to 4665895 Compare May 19, 2026 12:09
@pull-request-size
Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@MohamadJaara MohamadJaara force-pushed the mo/fix/conv-screan-reloading-when-navigating branch from 4665895 to 9647b39 Compare May 19, 2026 12:10
@MohamadJaara MohamadJaara changed the title fix: prevent the conv list from reloading when navigating back from a message screen fix: prevent the conv list from reloading when navigating back from a message screen [WPB-8645] May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.16%. Comparing base (a0e973d) to head (9647b39).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4827   +/-   ##
========================================
  Coverage    51.16%   51.16%           
========================================
  Files          611      611           
  Lines        21139    21139           
  Branches      3399     3399           
========================================
  Hits         10816    10816           
  Misses        9308     9308           
  Partials      1015     1015           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e973d...9647b39. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@MohamadJaara MohamadJaara requested a review from Garzas May 19, 2026 12:16
@MohamadJaara MohamadJaara enabled auto-merge May 19, 2026 15:12
auto-merge was automatically disabled May 20, 2026 08:23

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants