Revert #867 and note addTrack/removeTrack don't fire events#1062
Open
jan-ivar wants to merge 1 commit into
Open
Revert #867 and note addTrack/removeTrack don't fire events#1062jan-ivar wants to merge 1 commit into
jan-ivar wants to merge 1 commit into
Conversation
youennf
approved these changes
Jan 8, 2026
Contributor
|
We might want to ensure that we have a test when addTrack/removeTrack is called and no event is fired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts accidental normative changes in the editorial #867, and adds a note to avoid future confusion.
This restores behavior clarified in #517 (comment), which is that the addTrack() and removeTrack() methods on the MediaStream itself do not fire events.
Preview | Diff