TURBOPACK: fix subpath imports resolving to dependencies#93914
Open
yuzheng14 wants to merge 1 commit into
Open
TURBOPACK: fix subpath imports resolving to dependencies#93914yuzheng14 wants to merge 1 commit into
yuzheng14 wants to merge 1 commit into
Conversation
Allow package.json subpath imports targets to resolve as bare package specifiers instead of always forcing relative paths. Add a snapshot fixture that verifies an imports entry can point to a dependency in node_modules.
mischnic
reviewed
May 18, 2026
Comment on lines
3285
to
3286
| // Remove the Pattern::Constant(rcstr!("./")), from above again | ||
| old_request_key.push_front(rcstr!("./").into()); |
Member
There was a problem hiding this comment.
If the non-./-appended pattern above matched, then this would be wrong.
Author
There was a problem hiding this comment.
If the non-
./-appended pattern above matched, then this would be wrong.
This branch won't be reached when resolving Imports fields, because we're using Pattern::Constant. In that case, req.as_constant_string() will alwyas return Some, so the branch condition never matches.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.json#importshandling so subpath imports can resolve to bare package specifiers.exportsand relative subpath import targets.node_modules.Previously, the existing
#depcase could appear to work because Turbopack always prepended./to the resolved target. That turned"dep"into"./dep", and the fixture happened to contain a matching local./depdirectory. This did not cover the valid subpath imports case where the target should be resolved as an external package dependency.Test plan
lint-staged, includingrustfmt, Prettier, and ESLint for the staged files.subpath-importssnapshot fixture and output.Made with Cursor