fix: add CSP nonce to component chunk scripts#93904
Open
IxayWolf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds the parsed CSP nonce to App Router component convention chunk scripts emitted by
createComponentStylesAndScripts.Why?
Next already applies
ctx.nonceto similar_nextscript tags inget-layer-assets, andnext/dynamicpreload nonce propagation was fixed in #81999. This path still emitted/_next/static/chunks/...scripts without a nonce, which can triggerscript-src-elemviolations under nonce-based CSP policies.How?
Passes
nonce: ctx.noncewhen creating component convention script tags, and extends the CSP nonce e2e fixture with a clienttemplateroute that exercises this renderer and asserts chunk scripts include the nonce.Fixes #93903
LLM disclosure: Codex helped prepare this PR; I reviewed the change.
Local checks:
git diff --check. I could not run the e2e suite in this fresh checkout because dependencies are not installed locally.