Skip to content

Enable rootParams by default#93863

Open
gnoff wants to merge 1 commit into
canaryfrom
jstory/remove-rootparams-flag
Open

Enable rootParams by default#93863
gnoff wants to merge 1 commit into
canaryfrom
jstory/remove-rootparams-flag

Conversation

@gnoff
Copy link
Copy Markdown
Contributor

@gnoff gnoff commented May 14, 2026

rootParams is now available by default. the flag is removed.

There are still intentional limitations. For instance rootParams cannot be used in route handlers and Server Actions. The feature will be expanded with some support for this in the future.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 14, 2026

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

@gnoff gnoff force-pushed the jstory/remove-rootparams-flag branch from 5a5f214 to 2609941 Compare May 14, 2026 23:05
rootParams is now available by default. the flag is removed.

There are still intentional limitations. For instance rootParams cannot be used in route handlers and Server Actions. The feature will be expanded with some support for this in the future.
@gnoff gnoff force-pushed the jstory/remove-rootparams-flag branch from 2609941 to e83b672 Compare May 14, 2026 23:08
@github-actions
Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
Webpack Build Time (cached) 24.259s 24.761s 🔴 +502ms (+2%) ▂▃▄█▇
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 811ms 812ms ▅▂▅▄█
Cold (Ready in log) 775ms 776ms ▁▅▁▅▇
Cold (First Request) 1.187s 1.183s ▁▄▁▄█
Warm (Listen) 812ms 811ms ▃▁▆▁█
Warm (Ready in log) 779ms 775ms ▁▇▁██
Warm (First Request) 577ms 574ms ▁▆▁██
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 812ms 813ms ▅▁▇▇▇
Cold (Ready in log) 784ms 779ms ▄▄▅▇█
Cold (First Request) 3.192s 3.211s ▂▃▄▅▇
Warm (Listen) 812ms 812ms ▁▁▅▅▅
Warm (Ready in log) 781ms 782ms ▄▄▅▅█
Warm (First Request) 3.209s 3.228s ▄▆▄▄█

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.627s 4.676s ▁▄▁▃█
Cached Build 4.642s 4.656s ▁▄▁▆█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 24.338s 24.308s ▁▁▃█▆
Cached Build 24.259s 24.761s 🔴 +502ms (+2%) ▂▃▄█▇
node_modules Size 506 MB 506 MB ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
0-_5zcp4erz06.js gzip 155 B N/A -
04hm05ar7kldw.js gzip 5.73 kB N/A -
0c2d37sbzdihx.js gzip 70.9 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0dvitrl5zg37g.js gzip 8.82 kB N/A -
0sf7ysou-72zd.js gzip 8.71 kB N/A -
157abun3hwc_s.js gzip 10.3 kB N/A -
17x5h-qqxhzrx.js gzip 154 B N/A -
1a87ez4a5ecgj.js gzip 156 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1g3whbu20hkn7.js gzip 155 B N/A -
1jj68jv9537mc.js gzip 13.8 kB N/A -
1jpaub6y8xlfr.js gzip 2.3 kB N/A -
1ot0mvscrc_uf.js gzip 233 B N/A -
1xu8iw0j0r_tg.js gzip 151 B N/A -
1z3ut8arlyv-i.js gzip 160 B N/A -
1zjhxeflzl-vy.js gzip 159 B N/A -
2_m3xv2uq3sjc.js gzip 1.46 kB N/A -
24qtz2uzl4wst.js gzip 155 B N/A -
24y34mwgrkqp4.js gzip 8.78 kB N/A -
2b9eovwn8litd.js gzip 167 B N/A -
2c-fd4y1zozz8.js gzip 8.79 kB N/A -
2d7416h_xd36x.js gzip 8.71 kB N/A -
2g21ny1t2kw37.js gzip 7.61 kB N/A -
2lyuhit6rn8fy.js gzip 9.44 kB N/A -
2m04xa7h1rs-q.js gzip 154 B N/A -
2p2xgspe77mv3.js gzip 50.2 kB N/A -
2q0gr8wfr3jwl.js gzip 8.77 kB N/A -
2slg72_yqs010.js gzip 153 B N/A -
2t9e75oz6r0zp.js gzip 8.76 kB N/A -
2uku_olcn15b7.js gzip 8.79 kB N/A -
30r8mm-46bdqy.js gzip 220 B 220 B
3c1jdxkzlb8oq.js gzip 12.9 kB N/A -
3inab2jybr4k9.js gzip 450 B N/A -
3jkm5tdjvaf_q.js gzip 13.1 kB N/A -
3lo6ux8llsnmh.js gzip 155 B N/A -
3mt67agm5wp40.js gzip 10.6 kB N/A -
3rssl3skxqw0e.js gzip 65.6 kB N/A -
3saabek4kohwi.js gzip 10 kB N/A -
3xx6s_ieg68am.js gzip 155 B N/A -
4189xmby9yu1p.js gzip 13.6 kB N/A -
turbopack-03..4q7w.js gzip 4.21 kB N/A -
turbopack-1g..3ss7.js gzip 4.2 kB N/A -
turbopack-1k..w81a.js gzip 4.18 kB N/A -
turbopack-1q..-ok_.js gzip 4.2 kB N/A -
turbopack-22..xlgf.js gzip 4.2 kB N/A -
turbopack-2j..-i08.js gzip 4.2 kB N/A -
turbopack-2m..lvl1.js gzip 4.19 kB N/A -
turbopack-2n..6oym.js gzip 4.2 kB N/A -
turbopack-2q..ly21.js gzip 4.2 kB N/A -
turbopack-2z..p4tc.js gzip 4.2 kB N/A -
turbopack-2z..7_r3.js gzip 4.2 kB N/A -
turbopack-36..6bnx.js gzip 4.2 kB N/A -
turbopack-3h..ye_7.js gzip 4.2 kB N/A -
turbopack-3u..zpvr.js gzip 4.2 kB N/A -
0_i7nqgx23st7.js gzip N/A 10 kB -
06puhytyxk31p.js gzip N/A 8.82 kB -
0fi0ogq0bwa6w.js gzip N/A 156 B -
0fuas45e3_c21.js gzip N/A 155 B -
0inuwrr_z3vqy.js gzip N/A 157 B -
0j42f9zonj0wd.js gzip N/A 13 kB -
0m34gln_kt4fg.js gzip N/A 5.73 kB -
0sy8u1vi8lp5q.js gzip N/A 160 B -
0tw7eybgj56wj.js gzip N/A 162 B -
1-ewshnd9bzgq.js gzip N/A 50.2 kB -
1c9f_65chmta6.js gzip N/A 152 B -
1g3q1ww01thnl.js gzip N/A 2.3 kB -
1hraqxuiymq6v.js gzip N/A 8.79 kB -
1l9un1sl77287.js gzip N/A 1.46 kB -
1m4eug5ntv_6s.js gzip N/A 158 B -
21-eavqb1k_36.js gzip N/A 13.9 kB -
2147zgtf14z-q.js gzip N/A 234 B -
23bz3xsg-5-1s.js gzip N/A 8.71 kB -
27441mytv7pbm.js gzip N/A 9.43 kB -
29glh04g2fky_.js gzip N/A 155 B -
2bvt07mcvgwk5.js gzip N/A 70.9 kB -
2cjkwjgm1zcfs.js gzip N/A 8.71 kB -
2juhakbhezws1.js gzip N/A 155 B -
2nvrrw4th6joh.js gzip N/A 156 B -
2scd8zaoyb8md.js gzip N/A 8.79 kB -
2st_qs6p_9us0.js gzip N/A 13.1 kB -
2yjp27e2w0jqk.js gzip N/A 157 B -
2zo2exm1d8qj1.js gzip N/A 13.6 kB -
3_3acx7-vxc4d.js gzip N/A 170 B -
38d-gyinlsucy.js gzip N/A 155 B -
3ehsq7o481snb.js gzip N/A 65.6 kB -
3f710q6kll2xn.js gzip N/A 7.61 kB -
3hn75zuxly9az.js gzip N/A 10.3 kB -
3hqh7m128tvsn.js gzip N/A 8.77 kB -
3hqti_t-zy1x4.js gzip N/A 449 B -
3mnawenie1flm.js gzip N/A 8.76 kB -
3ubsozlu6zs38.js gzip N/A 10.6 kB -
43iwfqjnx1cy_.js gzip N/A 8.78 kB -
turbopack-05..7ncy.js gzip N/A 4.2 kB -
turbopack-0b..v1vw.js gzip N/A 4.2 kB -
turbopack-1f..ft9l.js gzip N/A 4.21 kB -
turbopack-1r..0jem.js gzip N/A 4.2 kB -
turbopack-1x..m7up.js gzip N/A 4.2 kB -
turbopack-22..gj3o.js gzip N/A 4.2 kB -
turbopack-23..a1fe.js gzip N/A 4.2 kB -
turbopack-2a..bl3v.js gzip N/A 4.2 kB -
turbopack-2c..vpvm.js gzip N/A 4.2 kB -
turbopack-2m.._6v6.js gzip N/A 4.18 kB -
turbopack-2v..o277.js gzip N/A 4.2 kB -
turbopack-3-..eqbs.js gzip N/A 4.2 kB -
turbopack-3k..-v4v.js gzip N/A 4.2 kB -
turbopack-3n..qcfi.js gzip N/A 4.2 kB -
Total 469 kB 469 kB ⚠️ +113 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 716 B 721 B
Total 716 B 721 B ⚠️ +5 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 432 B 433 B
Total 432 B 433 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2258-HASH.js gzip 61.4 kB N/A -
2266-HASH.js gzip 4.69 kB N/A -
3317.HASH.js gzip 169 B N/A -
4866-HASH.js gzip 5.64 kB N/A -
9e302639-HASH.js gzip 62.8 kB N/A -
framework-HASH.js gzip 59.5 kB 59.5 kB
main-app-HASH.js gzip 255 B 255 B
main-HASH.js gzip 39.9 kB 39.9 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
175fd0fd-HASH.js gzip N/A 62.8 kB -
2596-HASH.js gzip N/A 5.63 kB -
34-HASH.js gzip N/A 61.3 kB -
5691.HASH.js gzip N/A 169 B -
9156-HASH.js gzip N/A 4.68 kB -
Total 236 kB 236 kB ✅ -99 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 181 B 182 B
css-HASH.js gzip 334 B 332 B
dynamic-HASH.js gzip 1.79 kB 1.81 kB
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 351 B 348 B
hooks-HASH.js gzip 385 B 384 B
image-HASH.js gzip 580 B 580 B
index-HASH.js gzip 257 B 259 B
link-HASH.js gzip 2.51 kB 2.52 kB
routerDirect..HASH.js gzip 318 B 319 B
script-HASH.js gzip 387 B 386 B
withRouter-HASH.js gzip 316 B 316 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.99 kB ⚠️ +19 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 276 kB 270 kB 🟢 5.31 kB (-2%)
Total 402 kB 396 kB ✅ -5.53 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 620 B 615 B
middleware-r..fest.js gzip 155 B 155 B
middleware.js gzip 44.9 kB 44.8 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 46.5 kB 46.4 kB ✅ -58 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 719 B 717 B
Total 719 B 717 B ✅ -2 B
Build Cache
Canary PR Change
0.pack gzip 4.49 MB 4.48 MB 🟢 4.71 kB (0%)
index.pack gzip 114 kB 115 kB
index.pack.old gzip 115 kB 114 kB
Total 4.72 MB 4.71 MB ✅ -4.34 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 350 kB 350 kB
app-page-exp..prod.js gzip 195 kB 195 kB
app-page-tur...dev.js gzip 350 kB 350 kB
app-page-tur..prod.js gzip 194 kB 194 kB
app-page-tur...dev.js gzip 346 kB 346 kB
app-page-tur..prod.js gzip 192 kB 192 kB
app-page.run...dev.js gzip 347 kB 347 kB
app-page.run..prod.js gzip 193 kB 193 kB
app-route-ex...dev.js gzip 77.5 kB 77.5 kB
app-route-ex..prod.js gzip 52.9 kB 52.9 kB
app-route-tu...dev.js gzip 77.6 kB 77.6 kB
app-route-tu..prod.js gzip 52.9 kB 52.9 kB
app-route-tu...dev.js gzip 77.2 kB 77.2 kB
app-route-tu..prod.js gzip 52.7 kB 52.7 kB
app-route.ru...dev.js gzip 77.1 kB 77.1 kB
app-route.ru..prod.js gzip 52.7 kB 52.7 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 44.3 kB 44.3 kB
pages-api-tu..prod.js gzip 33.8 kB 33.8 kB
pages-api.ru...dev.js gzip 44.3 kB 44.3 kB
pages-api.ru..prod.js gzip 33.7 kB 33.7 kB
pages-turbo....dev.js gzip 53.7 kB 53.7 kB
pages-turbo...prod.js gzip 39.4 kB 39.4 kB
pages.runtim...dev.js gzip 53.6 kB 53.6 kB
pages.runtim..prod.js gzip 39.4 kB 39.4 kB
server.runti..prod.js gzip 63.1 kB 63.1 kB
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB
use-cache-pr...dev.js gzip 68 kB 68 kB
use-cache-pr...dev.js gzip 68 kB 68 kB
Total 3.37 MB 3.37 MB ✅ -3 B
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/e83b672edab1dc6acac02fb72b1bbd18508f2e50/next

Commit: e83b672

@github-actions
Copy link
Copy Markdown
Contributor

Failing test suites

Commit: e83b672 | About building and testing Next.js

pnpm test-dev test/development/acceptance-app/rsc-build-errors.test.ts (job)

  • Error overlay - RSC build errors > next/root-params > importing a non-existent getter from 'next/root-params' (DD)
Expand output

● Error overlay - RSC build errors › next/root-params › importing a non-existent getter from 'next/root-params'

expect(received).toInclude(expected)

Expected string to include:
  "Attempted import error: 'whatever' is not exported from 'next/root-params' (imported as 'whatever')."
Received:
  "app/server-with-errors/next-root-params/without-flag/page.js (4:27) @ Page·
  2 |
  3 | export default async function Page() {
> 4 |   return <>{await whatever()}</>
    |                           ^
  5 | }
  6 |"

  380 |       const { session } = sandbox
  381 |       await session.waitForRedbox()
> 382 |       expect(await session.getRedboxSource()).toInclude(
      |                                               ^
  383 |         isTurbopack
  384 |           ? `Export whatever doesn't exist in target module`
  385 |           : `Attempted import error: 'whatever' is not exported from 'next/root-params' (imported as 'whatever').`

  at Object.toInclude (development/acceptance-app/rsc-build-errors.test.ts:382:47)

pnpm test-dev test/development/typescript-app-type-declarations/typescript-app-type-declarations.test.ts (job)

  • typescript-app-type-declarations > should write a new next-env.d.ts if none exist (DD)
Expand output

● typescript-app-type-declarations › should write a new next-env.d.ts if none exist

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -1,8 +1,9 @@
  /// <reference types="next" />
  /// <reference types="next/image-types/global" />
  import "./.next/dev/types/routes.d.ts";
+ import "./.next/dev/types/root-params.d.ts";
  import "./.next/dev/types/cache-life.d.ts";
  import "./.next/dev/types/validator.ts";

  // NOTE: This file should not be edited
  // see https://nextjs.org/docs/pages/api-reference/config/typescript for more information.

  78 |     await retry(async () => {
  79 |       const content = await next.readFile('next-env.d.ts')
> 80 |       expect(content).toEqual(prevContent)
     |                       ^
  81 |     })
  82 |   })
  83 |

  at toEqual (development/typescript-app-type-declarations/typescript-app-type-declarations.test.ts:80:23)
  at retry (lib/next-test-utils.ts:867:14)
  at Object.<anonymous> (development/typescript-app-type-declarations/typescript-app-type-declarations.test.ts:78:5)

pnpm test-dev-turbo test/development/typescript-app-type-declarations/typescript-app-type-declarations.test.ts (turbopack) (job)

  • typescript-app-type-declarations > should write a new next-env.d.ts if none exist (DD)
Expand output

● typescript-app-type-declarations › should write a new next-env.d.ts if none exist

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -1,8 +1,9 @@
  /// <reference types="next" />
  /// <reference types="next/image-types/global" />
  import "./.next/dev/types/routes.d.ts";
+ import "./.next/dev/types/root-params.d.ts";
  import "./.next/dev/types/cache-life.d.ts";
  import "./.next/dev/types/validator.ts";

  // NOTE: This file should not be edited
  // see https://nextjs.org/docs/pages/api-reference/config/typescript for more information.

  78 |     await retry(async () => {
  79 |       const content = await next.readFile('next-env.d.ts')
> 80 |       expect(content).toEqual(prevContent)
     |                       ^
  81 |     })
  82 |   })
  83 |

  at toEqual (development/typescript-app-type-declarations/typescript-app-type-declarations.test.ts:80:23)
  at retry (lib/next-test-utils.ts:867:14)
  at Object.<anonymous> (development/typescript-app-type-declarations/typescript-app-type-declarations.test.ts:78:5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant