Update GitHub style and add GitHub darkmode#3
Closed
skullface wants to merge 3 commits into
Closed
Conversation
added 3 commits
August 9, 2019 14:55
styling
Author
Contributor
|
Sorry for late. But possible to submit this as an seperate theme on https://github.com/typora/typora-theme-gallery? You can name it like "Primer", or whatever you like. Typora use this as "default" theme (although it is named "Github" theme), so we should be much careful to change / modify this. |
Author
|
Thank so much @abnerlee! I think the name of the Typora default theme should be changed to "Default" since it’s not really accurate to GitHub’s styling. I will submit the PR to the theme gallery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 A happy Typora user and GitHub power user here!
💕 This PR:
Githubtheme to better align to GitHub’s Primer styling, specifically the PR/Issue view on GitHub.com.Like #2, this PR removes the custom font in favor of a native font stack.