-
Notifications
You must be signed in to change notification settings - Fork 12
Optionally use frontend inputs if provided #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hinshun
wants to merge
1
commit into
tonistiigi:master
Choose a base branch
from
hinshun:frontend-inputs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,10 @@ | ||
| # syntax=tonistiigi/dockerfile:runmount20181002 | ||
|
|
||
| FROM golang:1.11-alpine AS build | ||
| # syntax=docker/dockerfile-upstream:experimental | ||
| FROM golang:1.12-alpine AS build | ||
| WORKDIR /go/src/github.com/tonistiigi/buildkit-pack | ||
| RUN apk add --no-cache file | ||
| RUN apk add --no-cache file git | ||
| RUN --mount=target=. --mount=target=/root/.cache,type=cache \ | ||
| CGO_ENABLED=0 go build -o /out/pack ./cmd/pack && file /out/pack | grep "statically linked" | ||
| GO111MODULE=on CGO_ENABLED=0 go build -o /out/pack ./cmd/pack && file /out/pack | grep "statically linked" | ||
|
|
||
| FROM scratch | ||
| COPY --from=build /out/pack /bin/pack | ||
| ENTRYPOINT ["/bin/pack"] | ||
| ENTRYPOINT ["/bin/pack"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| module github.com/tonistiigi/buildkit-pack | ||
|
|
||
| go 1.12 | ||
|
|
||
| require ( | ||
| github.com/Microsoft/go-winio v0.4.14 | ||
| github.com/containerd/console v0.0.0-20181022165439-0650fd9eeb50 | ||
| github.com/containerd/containerd v1.4.0-0.20191014053712-acdcf13d5eaf | ||
| github.com/containerd/continuity v0.0.0-20200107194136-26c1120b8d41 | ||
| github.com/docker/distribution v2.7.1-0.20190205005809-0d3efadf0154+incompatible | ||
| github.com/docker/docker v1.14.0-0.20190319215453-e7b5f7dbe98c | ||
| github.com/gogo/googleapis v1.1.0 | ||
| github.com/gogo/protobuf v1.2.0 | ||
| github.com/golang/protobuf v1.2.0 | ||
| github.com/google/shlex v0.0.0-20150127133951-6f45313302b9 | ||
| github.com/grpc-ecosystem/grpc-opentracing v0.0.0-20180507213350-8e809c8a8645 | ||
| github.com/moby/buildkit v0.0.0-20181003224033-f07efb78e3f1 | ||
| github.com/morikuni/aec v0.0.0-20170113033406-39771216ff4c | ||
| github.com/opencontainers/go-digest v1.0.0-rc1 | ||
| github.com/opencontainers/image-spec v1.0.1 | ||
| github.com/opentracing/opentracing-go v0.0.0-20171003133519-1361b9cd60be | ||
| github.com/pkg/errors v0.8.1 | ||
| github.com/sirupsen/logrus v1.4.1 | ||
| github.com/tonistiigi/fsutil v0.0.0-20191018213012-0f039a052ca1 | ||
| github.com/tonistiigi/units v0.0.0-20180711220420-6950e57a87ea | ||
| github.com/urfave/cli v0.0.0-20171014202726-7bc6a0acffa5 | ||
| golang.org/x/net v0.0.0-20190522155817-f3200d17e092 | ||
| golang.org/x/sync v0.0.0-20190423024810-112230192c58 | ||
| golang.org/x/sys v0.0.0-20190812073006-9eafafc0a87e | ||
| golang.org/x/text v0.3.0 | ||
| golang.org/x/time v0.0.0-20161028155119-f51c12702a4d | ||
| google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8 | ||
| google.golang.org/grpc v1.23.0 | ||
| gopkg.in/yaml.v2 v2.2.2 | ||
| ) | ||
|
|
||
| replace github.com/moby/buildkit => github.com/hinshun/buildkit v0.0.0-20200124224350-99d18890d310 | ||
|
|
||
| replace github.com/hashicorp/go-immutable-radix => github.com/tonistiigi/go-immutable-radix v0.0.0-20170803185627-826af9ccf0fe | ||
|
|
||
| replace github.com/jaguilar/vt100 => github.com/tonistiigi/vt100 v0.0.0-20190402012908-ad4c4a574305 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if either of these cases, if input is not found it should default to
llb.Local. Even ifCapFrontendInputsis supported.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hinshun looks like this needs addressing if you still want to get this merged