"feat: integrate @solid/object and @volunteeringdata/object libraries#10
Open
PreciousOritsedere wants to merge 1 commit into
Open
"feat: integrate @solid/object and @volunteeringdata/object libraries#10PreciousOritsedere wants to merge 1 commit into
PreciousOritsedere wants to merge 1 commit into
Conversation
Collaborator
PreciousOritsedere
commented
May 19, 2026
PreciousOritsedere
commented
- Replace custom Agent with extension of @solid/object's Agent
- Remove redundant vocabulary constants handled by the library
- Delete WebIdDataset (no longer needed)
- Simplify profileUtils to use Agent constructor directly
- Replace wrapVolunteerProfile with VolunteerProfile constructor
- Add VCardValueNode workaround for @solid/object HasValue infinite recursion bug
- Add safeGet wrapper for graceful handling of Pod data mismatches
- Add structuralSharing: false for React Query Agent caching"
- Replace custom Agent with extension of @solid/object's Agent - Remove redundant vocabulary constants handled by the library - Delete WebIdDataset (no longer needed) - Simplify profileUtils to use Agent constructor directly - Replace wrapVolunteerProfile with VolunteerProfile constructor - Add VCardValueNode workaround for @solid/object HasValue infinite recursion bug - Add safeGet wrapper for graceful handling of Pod data mismatches - Add structuralSharing: false for React Query Agent caching"
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
langsamu
requested changes
May 19, 2026
| export class Agent extends BaseAgent { | ||
| /** | ||
| * Override email to avoid @solid/object's HasValue class which has a | ||
| * .value getter that conflicts with N3's termToId (causes infinite recursion). |
| get email(): string | null { | ||
| return this.hasEmail?.actualValue ?? null; | ||
| const emailNode = this.singularNullable(VCARD.hasEmail, TermAs.instance(VCardValueNode)); | ||
| if (!emailNode) return null; |
There was a problem hiding this comment.
Is there a good readon to return null? Otherwise let them all be undefined if they are optional.
Comment on lines
-146
to
+102
| return (addr != null && addr !== "") ? addr : null; | ||
| return addr != null && addr !== "" ? addr : null; |
There was a problem hiding this comment.
This change does not belong in this PR.
Comment on lines
+1
to
+11
| /** | ||
| * Extended Agent — adds project-specific properties on top of @solid/object's Agent. | ||
| * | ||
| * The base Agent from @solid/object already provides: | ||
| * vcardFn, foafName, name, email, hasEmail, phone, hasTelephone, | ||
| * organization, role, title, website, vcardHasUrl, foafHomepage, | ||
| * photoUrl, storageUrls, pimStorage, solidStorage, oidcIssuer, knows | ||
| * | ||
| * We extend only for properties not yet in the shared library. | ||
| */ | ||
|
|
There was a problem hiding this comment.
Please remove all comments that hinder readability and maintainability by redundantly explaining what the code does instead of why it does it.
Comment on lines
+1
to
+10
| /** | ||
| * Extended Agent — adds project-specific properties on top of @solid/object's Agent. | ||
| * | ||
| * The base Agent from @solid/object already provides: | ||
| * vcardFn, foafName, name, email, hasEmail, phone, hasTelephone, | ||
| * organization, role, title, website, vcardHasUrl, foafHomepage, | ||
| * photoUrl, storageUrls, pimStorage, solidStorage, oidcIssuer, knows | ||
| * | ||
| * We extend only for properties not yet in the shared library. | ||
| */ |
There was a problem hiding this comment.
Please remove all documentation comments that are actually explanatory comments.
| * Agent wrapping that WebID subject. | ||
| * | ||
| * Pure async — caching and dedup are handled by React Query (useAgent hook). | ||
| * Throws if the fetch or parse fails — the WebID is required for the app. |
There was a problem hiding this comment.
Please use JSDoc constructs like @throws where appropriate.
| queryFn: () => fetchAndParseProfile(webId!, fetchFn), | ||
| enabled: !!webId, | ||
| gcTime: Number.POSITIVE_INFINITY, | ||
| // The Agent object uses lazy getters that read from an RDF store on access. |
| gcTime: Number.POSITIVE_INFINITY, | ||
| // The Agent object uses lazy getters that read from an RDF store on access. | ||
| // React Query normally tries to compare old vs new data by walking every property, | ||
| // which would accidentally call those getters and cause errors. Turning this off |
| // React Query normally tries to compare old vs new data by walking every property, | ||
| // which would accidentally call those getters and cause errors. Turning this off | ||
| // tells React Query to just use the new Agent as-is without comparing it. | ||
| structuralSharing: false, |
Comment on lines
+78
to
+92
| /** | ||
| * Safely access an agent property that may throw at runtime. | ||
| * Some Solid Pods store data in unexpected formats (e.g. a plain text literal | ||
| * where the library expects a URL/NamedNode). When that happens, @rdfjs/wrapper | ||
| * throws a type error. We catch it here and return null so that one bad field | ||
| * doesn't break the entire profile. | ||
| */ | ||
| function safeGet<T>(fn: () => T): T | null { | ||
| try { | ||
| return fn(); | ||
| } catch { | ||
| return null; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Well known antipattern. Please handle the exceptional case properly or model in a different way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.