refactor: prepare ArchiveService for LogosStorage extension#7312
Merged
Conversation
Member
Jenkins BuildsClick to see older builds (225)
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (44.37%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7312 +/- ##
===========================================
- Coverage 61.23% 61.08% -0.15%
===========================================
Files 832 836 +4
Lines 116660 117158 +498
===========================================
+ Hits 71431 71562 +131
- Misses 37862 38214 +352
- Partials 7367 7382 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
from
6f8008f to
d085990
Compare
6 tasks
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
from
d085990 to
1144c71
Compare
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
from
1144c71 to
eb1981b
Compare
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
2 times, most recently
from
9188470 to
d9c5e4c
Compare
igor-sirotin
approved these changes
Feb 18, 2026
Collaborator
igor-sirotin
left a comment
igor-sirotin
left a comment
There was a problem hiding this comment.
Looks good, much cleaner now, thank you!
Collaborator
|
I think 44% patch is ok for this refactor |
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
from
44b799d to
b187d1e
Compare
|
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
from
9e57c28 to
dee7073
Compare
jrainville
approved these changes
Feb 26, 2026
| // CommunityExists checks if a community with the given ID exists in the database. | ||
| // This is a lightweight alternative to GetByID when only existence checking is needed. | ||
| func (p *Persistence) CommunityExists(memberIdentity *ecdsa.PublicKey, id []byte) (bool, error) { | ||
| r, err := p.getByID(id, memberIdentity) |
Member
There was a problem hiding this comment.
For a truly lightweight version, we could do a SELECT COUNT(1) FROM communities WHERE ID=id
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
2 times, most recently
from
634657a to
673e345
Compare
jrainville
force-pushed
the
refactor/extract-archive-service
branch
from
ff12faa to
5d1f1c4
Compare
Member
|
I rebased this branch and also created the companion PR: status-im/status-app#20208 |
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
2 times, most recently
from
9ef169f to
8aaa3dd
Compare
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
3 times, most recently
from
f354a68 to
f65df05
Compare
…ally slightly easier
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
from
f65df05 to
2a97883
Compare
marcinczenko
force-pushed
the
refactor/extract-archive-service
branch
from
2a97883 to
3bf31bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
status-app PR: status-im/status-app#20208
This PR brings new
ArchiveServicearchitecture. The new ArchiveService interface includes (by composition) theArchiveServiceBackendinterface (defined in the same file), which defines operations specific to the given archive storage technology (e.g. BitTorrent or LogosStorage).ArchiveServicealso defines its own technology independent operations.ArchiveServiceis implemented by ArchiveManager. On the construction using the factory function NewArchiveManager it instantiates either:Which concrete backend implementation will be instantiated depends on the content of the
amc *archivetypes.ArchiveManagerConfigargument to theNewArchiveManagerfactory function. If no appropriate configuration is found or none isEnabled, the factory returns a NOP implementation. This allows us to simplify the code in various places by removing a number of defensive checks. The NOP implementation will also be used whendisable_history_archivesbuild flag is defined (replaces previousdisable_torrentflag serving the same purpose).The lifecycle is also simplified. There is one intended way of instantiating
ArchiveManager(the above mentionedNewArchiveManagerfactory function) and theArchiveServiceinterface communicates clearly the intended public API hiding the backend and other implementation details. Still, to support the legacy tests (relevant test improvements may be considered in the future, but kept our of scope of this PR), bothArchiveManagerand the relevant backend implementations can provide additional methods accessible by bypassing theArchiveServiceinterface.All relevant sources are distributed across a number of packages under
protocol/communities/archiveto make decoupling from theprotocol/communitiespackage possible.For large majority of the code, the original functionality is preserved, with subtle interface adjustments to accommodate incoming
LogosStorageextension (which basically means providing a new backend implementation and archive technology-specific sources).