fix(chat): prevent MessageView from stealing ImageMessage right-clicks#20889
Merged
Conversation
friofry
requested review from
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins BuildsClick to see older builds (19)
|
friofry
force-pushed
the
ab/issue-20789-double-context-menu
branch
from
ceb2ec8 to
230b782
Compare
caybro
requested changes
May 18, 2026
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
Doesn't work on mobile, no image context menu at all
friofry
force-pushed
the
ab/issue-20789-double-context-menu
branch
from
230b782 to
ed5f44f
Compare
Contributor
Author
Combined 2 taphandlers into one: android-long-press.mp4 |
caybro
approved these changes
May 18, 2026
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
Works fine now 👍
Tested on Linux + Android; with mouse, keyboard, touchpad, and touchscreen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid mixing
MouseAreaandTapHandleron overlapping items, they don't see each other'sacceptedand both fire. Switched the image toTapHandlerso the parent message handler is properly suppressed.menu.mp4
fixes #20789