Skip to content

fix(browser): android connector #20885

Open
friofry wants to merge 7 commits into
release/2.38.xfrom
ab/issue-20602-android-connector
Open

fix(browser): android connector #20885
friofry wants to merge 7 commits into
release/2.38.xfrom
ab/issue-20602-android-connector

Conversation

@friofry
Copy link
Copy Markdown
Contributor

@friofry friofry commented May 15, 2026

updated:

  • Each tab now gets its own ConnectorBridge and WebChannel
  • Tab URL and metadata stay in sync per tab
  • RPC results are routed only to the tab that sent the request
  • The ethereum wrapper unsubscribes from QWebChannel signals on page unload

@friofry friofry requested review from a team, alexjba, caybro, micieslak and noeliaSD as code owners May 15, 2026 13:31
@friofry friofry requested review from anastasiyaig and dlipicar and removed request for a team May 15, 2026 13:31
@friofry friofry changed the base branch from master to release/2.34.x May 15, 2026 13:32
@anastasiyaig
Copy link
Copy Markdown
Contributor

@friofry wrong branch, it has to point to 2.38.x i think :D

@friofry friofry force-pushed the ab/issue-20602-android-connector branch from bd10fef to bd15609 Compare May 15, 2026 13:37
@friofry friofry changed the title Ab/issue 20602 android connector fix(browser): android connector May 15, 2026
@friofry friofry changed the base branch from release/2.34.x to release/2.38.x May 15, 2026 13:43
@status-im-auto
Copy link
Copy Markdown
Member

status-im-auto commented May 15, 2026

Jenkins Builds

Click to see older builds (71)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bd15609 4 2026-05-15 13:52:39 ~8 min tests/nim 📄log
✔️ bd15609 1 2026-05-15 13:54:43 ~10 min android/arm64 🤖apk 📲
✔️ bd15609 3 2026-05-15 13:55:43 ~11 min macos/aarch64 🍎dmg
✔️ bd15609 3 2026-05-15 13:56:08 ~12 min tests/ui 📄log
✔️ bd15609 4 2026-05-15 13:56:45 ~12 min ios/aarch64 📱ipa 📲
✔️ bd15609 4 2026-05-15 14:00:28 ~16 min linux/x86_64 📦tgz
✔️ bd15609 3 2026-05-15 14:18:45 ~34 min windows/x86_64 💿exe
✔️ bd15609 11266 2026-05-15 14:22:34 ~21 min tests/e2e 📊rpt
✖️ bd15609 3237 2026-05-15 15:40:33 ~1 hr 45 min tests/e2e-android 📦pkg
✔️ 121bb0eb 2 2026-05-18 08:21:34 ~10 min android/arm64 🤖apk 📲
✔️ f6e2027 5 2026-05-18 09:43:07 ~7 min tests/nim 📄log
✔️ f6e2027 3 2026-05-18 09:45:22 ~10 min android/arm64 🤖apk 📲
✔️ f6e2027 4 2026-05-18 09:47:50 ~12 min tests/ui 📄log
✔️ f6e2027 5 2026-05-18 09:49:57 ~14 min ios/aarch64 📱ipa 📲
✔️ f6e2027 5 2026-05-18 09:52:20 ~17 min linux/x86_64 📦tgz
✔️ f6e2027 4 2026-05-18 09:54:32 ~19 min macos/aarch64 🍎dmg
✔️ f6e2027 11277 2026-05-18 10:14:36 ~22 min tests/e2e 📊rpt
✔️ f6e2027 4 2026-05-18 10:20:04 ~44 min windows/x86_64 💿exe
✔️ f6e2027 3233 2026-05-18 10:56:38 ~36 min tests/e2e-windows 📊rpt
c35eff2 5 2026-05-19 16:00:46 ~5 min macos/aarch64 📄log
✔️ c35eff2 6 2026-05-19 16:03:21 ~8 min tests/nim 📄log
✔️ c35eff2 4 2026-05-19 16:05:40 ~11 min android/arm64 🤖apk 📲
✔️ c35eff2 5 2026-05-19 16:08:48 ~13 min tests/ui 📄log
✔️ c35eff2 6 2026-05-19 16:09:12 ~14 min ios/aarch64 📱ipa 📲
✔️ c35eff2 6 2026-05-19 16:14:02 ~19 min linux/x86_64 📦tgz
✔️ c35eff2 5 2026-05-19 16:29:55 ~35 min windows/x86_64 💿exe
✔️ c35eff2 11320 2026-05-19 16:30:41 ~16 min tests/e2e 📊rpt
✖️ c35eff2 3275 2026-05-19 16:56:32 ~26 min tests/e2e-windows 📊rpt
✔️ 132fe43 8 2026-05-19 18:44:40 ~7 min tests/nim 📄log
✔️ 132fe43 6 2026-05-19 18:46:16 ~9 min android/arm64 🤖apk 📲
✔️ 132fe43 8 2026-05-19 18:48:20 ~11 min ios/aarch64 📱ipa 📲
✔️ 132fe43 7 2026-05-19 18:50:43 ~13 min tests/ui 📄log
✔️ 132fe43 8 2026-05-19 18:56:17 ~19 min linux/x86_64 📦tgz
✔️ 132fe43 7 2026-05-19 19:06:24 ~29 min macos/aarch64 🍎dmg
✔️ 132fe43 7 2026-05-19 19:12:31 ~35 min windows/x86_64 💿exe
✔️ 132fe43 11325 2026-05-19 19:14:42 ~18 min tests/e2e 📊rpt
✔️ 132fe43 3279 2026-05-19 19:29:35 ~16 min tests/e2e-windows 📊rpt
✖️ 132fe43 3299 2026-05-19 20:30:46 ~1 hr 44 min tests/e2e-android 📦pkg
787c8da 9 2026-05-20 09:57:01 ~10 min linux/x86_64 📄log
787c8da 9 2026-05-20 10:00:20 ~13 min ios/aarch64 📄log
787c8da 8 2026-05-20 10:02:20 ~15 min macos/aarch64 📄log
✔️ 787c8da 8 2026-05-20 10:02:22 ~15 min tests/ui 📄log
✔️ 787c8da 9 2026-05-20 10:10:13 ~23 min tests/nim 📄log
787c8da 8 2026-05-20 10:10:54 ~24 min windows/x86_64 📄log
80ee3f4a 8 2026-05-20 10:52:24 ~15 min android/arm64 📄log
8f4286f 10 2026-05-20 11:30:57 ~11 min ios/aarch64 📄log
✔️ dc3496c 11 2026-05-20 11:53:39 ~16 min ios/aarch64 📱ipa 📲
✔️ dc3496c 10 2026-05-20 11:54:29 ~17 min android/arm64 🤖apk 📲
✔️ dc3496c 11 2026-05-20 12:00:52 ~23 min linux/x86_64 📦tgz
✔️ dc3496c 10 2026-05-20 12:10:37 ~33 min tests/ui 📄log
✔️ dc3496c 10 2026-05-20 12:15:12 ~37 min windows/x86_64 💿exe
✔️ dc3496c 3292 2026-05-20 12:31:51 ~16 min tests/e2e-windows 📊rpt
✔️ dc3496c 11342 2026-05-20 12:32:21 ~31 min tests/e2e 📊rpt
✔️ d10aa33 12 2026-05-20 13:01:23 ~17 min ios/aarch64 📱ipa 📲
✔️ d10aa33 11 2026-05-20 13:04:15 ~20 min macos/aarch64 🍎dmg
✔️ d10aa33 12 2026-05-20 13:04:40 ~20 min tests/nim 📄log
✔️ d10aa33 11 2026-05-20 13:06:01 ~22 min android/arm64 🤖apk 📲
✔️ d10aa33 11 2026-05-20 13:09:33 ~25 min tests/ui 📄log
✔️ d10aa33 12 2026-05-20 13:13:13 ~29 min linux/x86_64 📦tgz
✔️ d10aa33 11 2026-05-20 13:19:45 ~35 min windows/x86_64 💿exe
✔️ d10aa33 3296 2026-05-20 13:38:07 ~18 min tests/e2e-windows 📊rpt
✔️ d10aa33 11344 2026-05-20 13:51:04 ~37 min tests/e2e 📊rpt
✔️ 51a20d1 13 2026-05-20 14:04:34 ~16 min ios/aarch64 📱ipa 📲
✔️ 51a20d1 13 2026-05-20 14:09:20 ~20 min tests/nim 📄log
✔️ 51a20d1 12 2026-05-20 14:15:21 ~26 min tests/ui 📄log
✔️ e89802c 15 2026-05-20 14:53:32 ~15 min tests/nim 📄log
✔️ e89802c 15 2026-05-20 14:58:46 ~20 min linux/x86_64 📦tgz
✔️ e89802c 15 2026-05-20 15:00:05 ~22 min ios/aarch64 📱ipa 📲
e89802c 14 2026-05-20 15:00:08 ~22 min tests/ui 📄log
✔️ e89802c 14 2026-05-20 15:02:21 ~24 min macos/aarch64 🍎dmg
✔️ e89802c 11351 2026-05-20 15:19:55 ~21 min tests/e2e 📊rpt
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a948179 16 2026-05-20 15:13:53 ~10 min tests/nim 📄log
a948179 16 2026-05-20 15:19:46 ~16 min ios/aarch64 📄log
a948179 15 2026-05-20 15:20:30 ~16 min macos/aarch64 📄log
a948179 15 2026-05-20 15:21:36 ~18 min tests/ui 📄log
✔️ a948179 16 2026-05-20 15:29:55 ~26 min linux/x86_64 📦tgz
✔️ a948179 15 2026-05-20 15:45:12 ~41 min windows/x86_64 💿exe
✔️ a948179 11353 2026-05-20 15:56:11 ~26 min tests/e2e 📊rpt
✔️ a948179 3303 2026-05-20 16:04:06 ~18 min tests/e2e-windows 📊rpt
6816919a 15 2026-05-20 15:16:20 ~12 min android/arm64 📄log

@friofry
Copy link
Copy Markdown
Contributor Author

friofry commented May 15, 2026

@friofry wrong branch, it has to point to 2.38.x i think :D

I always forget to switch branch before clicking 'create' 😅

@sunleos
Copy link
Copy Markdown
Collaborator

sunleos commented May 15, 2026

@friofry,

tested APK # 1 on my Android 15.

no luck: the issue is still there (no Status connector installed)

image

@friofry friofry force-pushed the ab/issue-20602-android-connector branch from bd15609 to f6e2027 Compare May 18, 2026 09:34
@caybro caybro linked an issue May 18, 2026 that may be closed by this pull request
@friofry friofry force-pushed the ab/issue-20602-android-connector branch 3 times, most recently from 97b3e04 to 132fe43 Compare May 19, 2026 18:36
Copy link
Copy Markdown
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@friofry friofry force-pushed the ab/issue-20602-android-connector branch from 132fe43 to 787c8da Compare May 20, 2026 09:46
friofry added 2 commits May 20, 2026 13:46
* fix state correctness (connected flag)
* fixes OpenSea sign-in failing when another dApp tab (e.g. hub) is open
* fix stale listeners when reloading a page

Fixes #20602
@friofry friofry force-pushed the ab/issue-20602-android-connector branch from 787c8da to 8f4286f Compare May 20, 2026 11:19
@friofry friofry force-pushed the ab/issue-20602-android-connector branch from 8f4286f to dc3496c Compare May 20, 2026 11:36
@sunleos
Copy link
Copy Markdown
Collaborator

sunleos commented May 20, 2026

tested build 10: no luck the issue is still reproducible, plus in this build reloading your web screen doesn't help anymore

image

@friofry friofry force-pushed the ab/issue-20602-android-connector branch 4 times, most recently from e89802c to a948179 Compare May 20, 2026 15:03
@friofry friofry force-pushed the ab/issue-20602-android-connector branch from a948179 to 671a882 Compare May 20, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Browser] dApps don't see our Status connector

6 participants