Safearea bottom sheet simplifications, warnings eliminated#20868
Open
micieslak wants to merge 1 commit into
Open
Safearea bottom sheet simplifications, warnings eliminated#20868micieslak wants to merge 1 commit into
micieslak wants to merge 1 commit into
Conversation
micieslak
force-pushed
the
fix/issue-20867-safearea-bottom-sheet-simplifications
branch
from
7965722 to
eb2088f
Compare
Member
Jenkins BuildsClick to see older builds (10)
|
sunleos
approved these changes
May 14, 2026
Collaborator
sunleos
left a comment
sunleos
left a comment
There was a problem hiding this comment.
tested
have not spotted any issues
noeliaSD
approved these changes
May 15, 2026
Collaborator
noeliaSD
left a comment
noeliaSD
left a comment
There was a problem hiding this comment.
Code LGTM. I run a manual test on iPhone and didn't catch any safe area issue.
Collaborator
|
Hey @noeliaSD, Michal is off today, let's merge this PR if there is nothing else left to fix/correct. |
Member
It has conflicts... |
Member
|
The change to main.qml is not trivial, and with the recent code overhaul the conflict is rather complex :) I'd wait for @micieslak with this one |
Member
|
@micieslak need to fix the conflicts and merge :) |
It elminates logical circular dependencies and binding loop warnings.
micieslak
force-pushed
the
fix/issue-20867-safearea-bottom-sheet-simplifications
branch
from
eb2088f to
9c5c5a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
It elminates logical circular dependencies and binding loop warnings.
Closes: #20867
Affected areas
main.qml,StatusDropdownQuality checklist
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
Low
How to test
Navigate to various sections, trigger popups, interact with the virtual keyboard on mobile
Risk
Risk of regression related to safe areas