fdroid: nuke self signing and make builds reproducible#20807
Open
siddarthkay wants to merge 3 commits into
Open
fdroid: nuke self signing and make builds reproducible#20807siddarthkay wants to merge 3 commits into
siddarthkay wants to merge 3 commits into
Conversation
Member
Jenkins BuildsClick to see older builds (58)
|
siddarthkay
force-pushed
the
fdroid-unsigned-reproducible
branch
from
7ba7df5 to
2e541bd
Compare
siddarthkay
force-pushed
the
fdroid-unsigned-reproducible
branch
5 times, most recently
from
0afdeb4 to
5ba93cc
Compare
siddarthkay
force-pushed
the
fdroid-unsigned-reproducible
branch
from
5ba93cc to
f3f6548
Compare
For releasing we still need a signed APK. Fdroid will compare fingerprint of this APK and use it on their releases.
jakubgs
approved these changes
May 15, 2026
Comment on lines
+100
to
+114
| def keystore = creds.androidKeystorePrefix() | ||
| withCredentials([ | ||
| file( | ||
| credentialsId: "${keystore}-file", | ||
| variable: 'KEYSTORE_PATH' | ||
| ), | ||
| string( | ||
| credentialsId: "${keystore}-pass", | ||
| variable: 'KEYSTORE_PASSWORD' | ||
| ), | ||
| usernamePassword( | ||
| credentialsId: "${keystore}-key-pass", | ||
| usernameVariable: 'KEYSTORE_ALIAS', | ||
| passwordVariable: 'KEYSTORE_KEY_PASSWORD' | ||
| ), |
Member
There was a problem hiding this comment.
Try not to provide credentials in Jenkinsfiles. Use our jenkins lib for that.
Member
There was a problem hiding this comment.
Also, why not use fdroid/generate-keystore.sh as we did before?
Comment on lines
+116
to
+121
| /* apksigner is provided by the fdroid agent image (fdroid/Dockerfile). | ||
| * The F-Droid build emits a zipaligned, unsigned APK, so signing | ||
| * in place is sufficient. Passwords are passed via env: provider | ||
| * to keep them off the process command line. */ | ||
| sh ''' | ||
| set +x |
Member
There was a problem hiding this comment.
Or we could just wrap it into a script too. What was wrong with fdroid/sign-apk.sh?
Contributor
Author
There was a problem hiding this comment.
The problem with using a single use keystore is that Fdroid will use our signed apk as part of their releases ( if we enable reproducible builds as part of the manifest ).
If we regenerate keystore each time users won't be able to update the app since it would have been signed each time with different key.
Comment on lines
+51
to
+54
| GOFLAGS="-trimpath -buildvcs=false" \ | ||
| GOMODCACHE="$(BUILD_PATH)/.gomodcache" \ | ||
| CGO_CFLAGS="-ffile-prefix-map=$(HOME)=." \ | ||
| CGO_CXXFLAGS="-ffile-prefix-map=$(HOME)=." \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.