Skip to content

Enable parallel state root computation by default #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhartnett merged 2 commits into from
May 19, 2026
+3 −3
Merged

Enable parallel state root computation by default #4247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8da626b
Enable parallel state root computation by default.
bhartnett May 15, 2026
1d6ac09
Update config test.
bhartnett May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion execution_chain/conf.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ type

parallelStateRootComputation* {.
hidden
defaultValue: false
defaultValue: true
Copy link
Copy Markdown
Contributor Author

@bhartnett bhartnett May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@advaita-saha How has your node been going with this enabled so far? Do you think we should make this enabled by default?

desc: "Compute state root in parallel using multiple threads"
name: "debug-parallel-state-root".}: bool

Expand Down
4 changes: 2 additions & 2 deletions tests/test_configuration.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,8 @@ proc configurationMain*() =
check config.rdbBranchCacheSize == 39
check config.rdbPrintStats == true
check config.rewriteDatadirId == true
check config.eagerStateRootCheck == false
check config.parallelStateRootComputation == false
check config.eagerStateRootCheck == false
check config.parallelStateRootComputation == true
check config.statelessProviderEnabled == true
check config.statelessWitnessValidation == true

Expand Down
Loading