fix network argument to be a string and not a list#4243
Conversation
Tried using TOML config format and encountered this unexpected error: Failed to load secondary sources: 'nimbus-execution-client.toml(17, 11) expected '"["'' Signed-off-by: Jakub Sokołowski <jakub@status.im>
|
The reason it is a list is nimbus can accept:
The 3rd & 4th version allow nimbus to override the numerical network id. |
|
If overriding network ID is required why not have separate Also, why would overriding the network ID be desirable in the first place? |
|
In the past nimbus have And why overriding network ID is needed? Looks like geth genesis file format is very popular among client implementer. But it does not contains network ID. It force chain ID to be used as network ID which is not always true. override network ID is a clean mechanism when client user want a different network ID from chain ID. (So it's an external/historical complexity) And why providing genesis file shouldn't be a separate flag as well? both genesis file and built in named network are the same thing. You can choose a built in named network such as For now, isn't using bracket for your |
Tried using TOML config format and encountered this unexpected error: