Rpc error handling#4171
Open
RazorClient wants to merge 9 commits into
Open
Conversation
f028035 to
5325cba
Compare
5325cba to
61acdc3
Compare
46ce9cf to
8261043
Compare
81d79b3 to
0986356
Compare
Contributor
Author
|
This PR cleans up the RPC error handling semantics by introducing
The debug level failures are now removed from this pr as it doesn't fit in with the new ethjson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr introduces the Result[Opt[T], string] semantics to the rpc layer that allows us to handle the case where we need to differentiate between
also adds the tail semantics from the pruner to "earliest" tag resolution
address reviews