Add peek to AsyncQueue#557
Open
bhartnett wants to merge 4 commits into
Open
Conversation
arnetheduck
reviewed
Oct 3, 2024
| ## Alias of ``popFirst()``. | ||
| aq.popFirst() | ||
|
|
||
| proc peak*[T](aq: AsyncQueue[T]): Future[T] {. |
Member
There was a problem hiding this comment.
Suggested change
| proc peak*[T](aq: AsyncQueue[T]): Future[T] {. | |
| proc peek*[T](aq: AsyncQueue[T]): Future[T] {. |
Author
There was a problem hiding this comment.
My bad, will fix the spelling shortly.
arnetheduck
reviewed
Oct 3, 2024
| q.putNoWait(1) | ||
| q.putNoWait(2) | ||
|
|
||
| check: |
Member
There was a problem hiding this comment.
there needs to be a test here that ensures that the following also works:
let a = q.peekFirst()
let b = q.popFirst()
both in that order and in the reverse order - where peek-after-pop should probably not trigger
Author
There was a problem hiding this comment.
I've added more tests as suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some of my code I found the need to do something like this:
Having an async peek proc that waits for the first item to be added to the queue would be good. The std/deques supports peekFirst and peekLast as well so this PR adds these to the AsyncQueue.