Add minimal reify#818
Open
willcohen wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
This works on these synthetic tests but isn't actually working downstream. This needs more work. |
willcohen
force-pushed
the
reify
branch
4 times, most recently
from
f747550 to
fcf7fd5
Compare
Contributor
Author
|
This is actually okay independent -- my other usages surfaced other small issues that I need to work through separately. I added one more test just to confirm that this solves what it needs to for reify. Ready for review @borkdude |
Contributor
Author
|
Merging in #820 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an [issue with a clear problem statement]
Add reify #817
This PR contains a test to prevent against future regressions
Uncomments the stubs plus adds a new
reify-testI have updated the CHANGELOG.md file with a description of the addressed issue.
Notes Add reify #817.
Let me know if you have any questions! I left the unused args as
_ _-- I saw some discrepancy betweensquint/src/squint/compiler.cljc
Line 296 in db49293
form envbutsquint/src/squint/internal/protocols.cljc
Line 28 in db49293
squint/src/squint/internal/protocols.cljc
Line 102 in db49293
envprecedingform.squint/src/squint/internal/protocols.cljc
Line 157 in db49293
_ _, so I went with that.