Assorted fixes to allow reading namespaces in cljc macros.#188
Draft
willcohen wants to merge 3 commits into
Draft
Assorted fixes to allow reading namespaces in cljc macros.#188willcohen wants to merge 3 commits into
willcohen wants to merge 3 commits into
Conversation
Contributor
Author
|
I'm gonna stop repeatedly churning all these other pending things, but this isn't actually connected to test-check anymore, and really just needs to depend on whatever version of squint gets something like squint-cljs/squint#805. I'm gonna leave this as is for now, but I would eventually like to do one more force push before this branch is 'ready' because "WIP squint deps bump, to be removed after #186 lands" is unnecessary in commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an [issue with a clear problem statement] Macros in
.cljcfiles cannot read data from a:require'd.cljcnamespace #187 (https://github.com/babashka/babashka/blob/master/doc/dev.md#start-with-an-issue-before-writing-code).This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.
No changelog updates yet. This requires more discussion in #187, and depending on how it looks this may need to get broken in a few pieces.